Skip to content

Test that ReadInConfig's error return is compatible#46832

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
dustin.long/viper-err-test
Feb 24, 2026
Merged

Test that ReadInConfig's error return is compatible#46832
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
dustin.long/viper-err-test

Conversation

@dustmop
Copy link
Contributor

@dustmop dustmop commented Feb 23, 2026

What does this PR do?

This is a follow-up to #46651, adding a unit test that validates the returned error for nodetreemodel matches that of viper.

Motivation

Viper compatibility.

Describe how you validated your changes

Unit test.

Additional Notes

@dustmop dustmop requested a review from a team as a code owner February 23, 2026 21:14
@dustmop dustmop requested a review from s-alad February 23, 2026 21:14
@dustmop dustmop added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-configuration labels Feb 23, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 23, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 23, 2026
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d37115c
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 756.616 MiB
agent_deb_amd64_fips 715.122 MiB
agent_heroku_amd64 323.758 MiB
agent_msi 622.700 MiB
agent_rpm_amd64 756.600 MiB
agent_rpm_amd64_fips 715.106 MiB
agent_rpm_arm64 734.722 MiB
agent_rpm_arm64_fips 696.240 MiB
agent_suse_amd64 756.600 MiB
agent_suse_amd64_fips 715.106 MiB
agent_suse_arm64 734.722 MiB
agent_suse_arm64_fips 696.240 MiB
docker_agent_amd64 817.637 MiB
docker_agent_arm64 820.494 MiB
docker_agent_jmx_amd64 1008.548 MiB
docker_agent_jmx_arm64 1000.188 MiB
docker_cluster_agent_amd64 203.414 MiB
docker_cluster_agent_arm64 217.834 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.500 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.724 MiB
dogstatsd_deb_arm64 27.881 MiB
dogstatsd_rpm_amd64 29.724 MiB
dogstatsd_suse_amd64 29.724 MiB
iot_agent_deb_amd64 42.609 MiB
iot_agent_deb_arm64 39.710 MiB
iot_agent_deb_armhf 40.439 MiB
iot_agent_rpm_amd64 42.609 MiB
iot_agent_suse_amd64 42.609 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -54.56 KiB (0.03% reduction) 185.720 → 185.667 → 186.090
agent_deb_amd64_fips +25.0 KiB (0.01% increase) 176.297 → 176.322 → 180.330
agent_heroku_amd64 +6.18 KiB (0.01% increase) 87.104 → 87.110 → 88.440
agent_msi +36.0 KiB (0.02% increase) 149.320 → 149.355 → 154.470
agent_rpm_amd64 -30.9 KiB (0.02% reduction) 187.599 → 187.569 → 189.170
agent_rpm_amd64_fips +22.17 KiB (0.01% increase) 178.417 → 178.438 → 181.060
agent_rpm_arm64 -13.59 KiB (0.01% reduction) 169.822 → 169.808 → 170.020
agent_rpm_arm64_fips +9.84 KiB (0.01% increase) 162.484 → 162.494 → 164.130
agent_suse_amd64 -30.9 KiB (0.02% reduction) 187.599 → 187.569 → 189.170
agent_suse_amd64_fips +22.17 KiB (0.01% increase) 178.417 → 178.438 → 181.060
agent_suse_arm64 -13.59 KiB (0.01% reduction) 169.822 → 169.808 → 170.020
agent_suse_arm64_fips +9.84 KiB (0.01% increase) 162.484 → 162.494 → 164.130
docker_agent_amd64 +3.48 KiB (0.00% increase) 277.909 → 277.912 → 279.410
docker_agent_arm64 neutral 265.187 MiB → 267.960
docker_agent_jmx_amd64 +4.56 KiB (0.00% increase) 346.548 → 346.553 → 348.040
docker_agent_jmx_arm64 neutral 329.831 MiB → 332.560
docker_cluster_agent_amd64 neutral 71.194 MiB → 71.920
docker_cluster_agent_arm64 neutral 66.834 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.237 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.852 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.741 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.864 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.864 MiB → 8.800
iot_agent_deb_amd64 neutral 11.232 MiB → 12.040
iot_agent_deb_arm64 neutral 9.598 MiB → 10.450
iot_agent_deb_armhf neutral 9.800 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.252 MiB → 12.060
iot_agent_suse_amd64 neutral 11.252 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 922acc12-789f-4a81-b01e-dad023d943b7

Baseline: d37115c
Comparison: fe444d3
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.98 [-2.13, +4.10] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.98 [-2.13, +4.10] 1 Logs
quality_gate_idle memory utilization +0.71 [+0.67, +0.76] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.58 [+0.47, +0.69] 1 Logs
quality_gate_idle_all_features memory utilization +0.50 [+0.46, +0.53] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.30 [+0.06, +0.53] 1 Logs
file_tree memory utilization +0.14 [+0.09, +0.19] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.06 [-0.10, +0.21] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.46, +0.56] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.01, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.13] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.41, +0.35] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.49, +0.36] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.08 [-0.14, -0.03] 1 Logs
otlp_ingest_metrics memory utilization -0.33 [-0.49, -0.17] 1 Logs
docker_containers_memory memory utilization -0.40 [-0.49, -0.32] 1 Logs
ddot_logs memory utilization -0.49 [-0.55, -0.43] 1 Logs
ddot_metrics_sum_delta memory utilization -0.57 [-0.77, -0.36] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.72 [-0.80, -0.65] 1 Logs
ddot_metrics memory utilization -0.78 [-0.97, -0.58] 1 Logs
quality_gate_metrics_logs memory utilization -0.91 [-1.11, -0.71] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.01 [-2.52, +0.50] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit dc3c3c7 into main Feb 24, 2026
332 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the dustin.long/viper-err-test branch February 24, 2026 01:48
@github-actions github-actions bot added this to the 7.78.0 milestone Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants