Draft
Conversation
Contributor
Go Package Import DifferencesBaseline: 6e8b562
|
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
from
b09fbb2 to
6c83e9f
Compare
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
from
6c83e9f to
467404f
Compare
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
from
467404f to
0680054
Compare
Contributor
Files inventory check summaryFile checks results against ancestor 6e8b5622: Results for datadog-agent_7.78.0~devel.git.619.78bb772.pipeline.103315267-1_amd64.deb:Detected file changes:
|
Contributor
Static quality checks❌ Please find below the results from static quality gates Error
Gate failure full details
Static quality gates prevent the PR to merge! Successful checksInfo
8 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6e8b562 Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -2.08 | [-5.10, +0.94] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otlp_ingest_metrics | memory utilization | +1.60 | [+1.44, +1.75] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +1.56 | [+1.50, +1.62] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +1.37 | [+1.30, +1.44] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.33 | [-0.30, +2.96] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.97 | [+0.91, +1.02] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.82 | [+0.76, +0.88] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.75 | [+0.50, +0.99] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.75 | [+0.65, +0.84] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.33 | [+0.29, +0.37] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.22 | [+0.16, +0.27] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.20 | [+0.06, +0.35] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.13 | [-0.09, +0.35] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.12 | [-0.06, +0.30] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.06 | [-0.11, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.04 | [-0.34, +0.42] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.17, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.00 | [-0.42, +0.42] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.08, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.21, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.49, +0.44] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.61 | [-1.72, -1.49] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -2.08 | [-5.10, +0.94] | 1 | Logs |
| ✅ | quality_gate_logs_with_processing_rules | % cpu utilization | -32.84 | [-32.95, -32.73] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 684 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.86MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 710 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ❌ | quality_gate_idle | memory_usage | 9/10 | 175.25MiB > 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 492.30MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 207.00MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs_with_processing_rules | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs_with_processing_rules | memory_usage | 10/10 | 212.74MiB ≤ 330MiB | bounds checks dashboard |
| ❌ | quality_gate_logs_with_processing_rules | missed_bytes | 0/10 | 722.24MiB > 0MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 338.02 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 411.92MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_logs_with_processing_rules, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs_with_processing_rules, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs_with_processing_rules, bounds check missed_bytes: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
3 times, most recently
from
a4eab5e to
7b5e117
Compare
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
3 times, most recently
from
3850139 to
c8afc74
Compare
ddrthall
force-pushed
the
ryan.hall/regex-optimizer
branch
from
c8afc74 to
e1293e5
Compare
Change include_at_match to exclude_at_match for rules that should be filtering out logs rather than selecting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes