APM: Avoid container ID resolution in non-container envs (APMS-18824)#47892
APM: Avoid container ID resolution in non-container envs (APMS-18824)#47892ajgajg1134 wants to merge 2 commits intomainfrom
Conversation
comp/trace/config/impl/setup.go
Outdated
| } | ||
| } else { | ||
| // In non-containerized environments, we will never be able to generate a container ID from the origin info, so don't bother the remote tagger. | ||
| cfg.ContainerIDFromOriginInfo = func(originInfo origindetection.OriginInfo) (string, error) { |
There was a problem hiding this comment.
I believe this would work, but maybe we can even create a noop ID Provider for situations where IsContainerized() is false? The current one would not use the origin info features, but would still look into headers for container info: https://github.com/DataDog/datadog-agent/blob/main/pkg/trace/api/container_linux.go#L136-L181
Files inventory check summaryFile checks results against ancestor b76b0b91: Results for datadog-agent_7.78.0~devel.git.630.d21f277.pipeline.103263415-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
26 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b76b0b9 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.37 | [-2.61, +3.36] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.20 | [+0.96, +1.44] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.85 | [+0.74, +0.96] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.58 | [+0.44, +0.73] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.37 | [-2.61, +3.36] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.37 | [+0.14, +0.59] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.23 | [+0.08, +0.38] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.12 | [+0.08, +0.17] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.10 | [+0.04, +0.16] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.08 | [-1.50, +1.65] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | +0.07 | [-0.11, +0.26] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.06 | [-0.01, +0.14] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.42, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.16, +0.17] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.37, +0.38] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.19, +0.18] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.01 | [-0.05, +0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.09, +0.06] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.02 | [-0.20, +0.15] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.50, +0.39] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.22 | [-0.32, -0.12] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.28 | [-0.34, -0.22] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.34 | [-0.39, -0.28] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 709 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 270.99MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 732 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 172.68MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 489.51MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 203.31MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 354.39 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 425.39MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
Propagates
env.IsContainerized()into the trace-agent config asIsContainerizedand, when false, uses a dedicated noopIDProviderinpkg/trace/apiso the trace API does not read HTTP headers or run cgroup/tagger logic for container ID resolution.Much of this was written with Cursor but all of it was reviewed by my human 👀
Motivation
In non-containerized environments the trace API was still parsing headers and (on Linux) doing cgroup lookups before the noop
ContainerIDFromOriginInfowas called. This change avoids that work entirely whenIsContainerizedis false, reducing unnecessary CPU load on the core Agent.Describe how you validated your changes
Lint (
dda inv linter.go) and tests (dda inv test) were run for./pkg/trace/config/...,./pkg/trace/api/...,./comp/trace/config/..., and./cmd/trace-agent/config/.... Unit tests that expect container ID resolution from headers were updated to setIsContainerized: true(andContainerIDFromOriginInfowhere required on Linux).e2e tests will also ensure no regressions. I also ran this locally outside a container to verify the lookup did not occur.
Additional Notes
IsContainerized: trueinconfig.New()keeps existing behavior for code paths that don’t go through setup (e.g. otel uses of trace-agent)