Skip to content

APM: Avoid container ID resolution in non-container envs (APMS-18824)#47892

Draft
ajgajg1134 wants to merge 2 commits intomainfrom
andrew.glaude/nocontODS
Draft

APM: Avoid container ID resolution in non-container envs (APMS-18824)#47892
ajgajg1134 wants to merge 2 commits intomainfrom
andrew.glaude/nocontODS

Conversation

@ajgajg1134
Copy link
Contributor

@ajgajg1134 ajgajg1134 commented Mar 16, 2026

What does this PR do?

Propagates env.IsContainerized() into the trace-agent config as IsContainerized and, when false, uses a dedicated noop IDProvider in pkg/trace/api so the trace API does not read HTTP headers or run cgroup/tagger logic for container ID resolution.

Much of this was written with Cursor but all of it was reviewed by my human 👀

Motivation

In non-containerized environments the trace API was still parsing headers and (on Linux) doing cgroup lookups before the noop ContainerIDFromOriginInfo was called. This change avoids that work entirely when IsContainerized is false, reducing unnecessary CPU load on the core Agent.

Describe how you validated your changes

Lint (dda inv linter.go) and tests (dda inv test) were run for ./pkg/trace/config/..., ./pkg/trace/api/..., ./comp/trace/config/..., and ./cmd/trace-agent/config/.... Unit tests that expect container ID resolution from headers were updated to set IsContainerized: true (and ContainerIDFromOriginInfo where required on Linux).

e2e tests will also ensure no regressions. I also ran this locally outside a container to verify the lookup did not occur.

Additional Notes

  • Default IsContainerized: true in config.New() keeps existing behavior for code paths that don’t go through setup (e.g. otel uses of trace-agent)

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 16, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-apm trace-agent labels Mar 16, 2026
}
} else {
// In non-containerized environments, we will never be able to generate a container ID from the origin info, so don't bother the remote tagger.
cfg.ContainerIDFromOriginInfo = func(originInfo origindetection.OriginInfo) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would work, but maybe we can even create a noop ID Provider for situations where IsContainerized() is false? The current one would not use the origin info features, but would still look into headers for container info: https://github.com/DataDog/datadog-agent/blob/main/pkg/trace/api/container_linux.go#L136-L181

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 16, 2026

Files inventory check summary

File checks results against ancestor b76b0b91:

Results for datadog-agent_7.78.0~devel.git.630.d21f277.pipeline.103263415-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 16, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b76b0b9
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_msi +2.0 KiB (0.00% increase) 601.884 → 601.886 → 1062.520
docker_agent_amd64 -3.81 KiB (0.00% reduction) 809.131 → 809.128 → 813.040
docker_agent_arm64 -3.57 KiB (0.00% reduction) 811.731 → 811.728 → 819.570
docker_agent_jmx_amd64 -3.8 KiB (0.00% reduction) 1000.047 → 1000.043 → 1003.920
docker_agent_jmx_arm64 -3.57 KiB (0.00% reduction) 991.425 → 991.422 → 999.170
26 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 748.797 MiB
agent_deb_amd64_fips 707.174 MiB
agent_heroku_amd64 311.697 MiB
agent_rpm_amd64 748.780 MiB
agent_rpm_amd64_fips 707.157 MiB
agent_rpm_arm64 726.579 MiB
agent_rpm_arm64_fips 687.887 MiB
agent_suse_amd64 748.780 MiB
agent_suse_amd64_fips 707.157 MiB
agent_suse_arm64 726.579 MiB
agent_suse_arm64_fips 687.887 MiB
docker_cluster_agent_amd64 203.669 MiB
docker_cluster_agent_arm64 218.167 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.615 MiB
docker_dogstatsd_arm64 36.939 MiB
dogstatsd_deb_amd64 29.846 MiB
dogstatsd_deb_arm64 27.995 MiB
dogstatsd_rpm_amd64 29.846 MiB
dogstatsd_suse_amd64 29.846 MiB
iot_agent_deb_amd64 43.050 MiB
iot_agent_deb_arm64 40.112 MiB
iot_agent_deb_armhf 40.848 MiB
iot_agent_rpm_amd64 43.050 MiB
iot_agent_suse_amd64 43.050 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -51.09 KiB (0.03% reduction) 174.732 → 174.682 → 177.700
agent_deb_amd64_fips -23.64 KiB (0.01% reduction) 165.675 → 165.652 → 172.230
agent_heroku_amd64 neutral 75.150 MiB → 79.970
agent_msi -16.0 KiB (0.01% reduction) 137.996 → 137.980 → 146.220
agent_rpm_amd64 +24.99 KiB (0.01% increase) 177.233 → 177.257 → 180.780
agent_rpm_amd64_fips -13.62 KiB (0.01% reduction) 167.739 → 167.726 → 173.370
agent_rpm_arm64 -41.89 KiB (0.03% reduction) 160.099 → 160.058 → 161.610
agent_rpm_arm64_fips +3.5 KiB (0.00% increase) 151.630 → 151.634 → 155.910
agent_suse_amd64 +24.99 KiB (0.01% increase) 177.233 → 177.257 → 180.780
agent_suse_amd64_fips -13.62 KiB (0.01% reduction) 167.739 → 167.726 → 173.370
agent_suse_arm64 -41.89 KiB (0.03% reduction) 160.099 → 160.058 → 161.610
agent_suse_arm64_fips +3.5 KiB (0.00% increase) 151.630 → 151.634 → 155.910
docker_agent_amd64 +7.38 KiB (0.00% increase) 267.839 → 267.846 → 271.240
docker_agent_arm64 neutral 255.166 MiB → 259.800
docker_agent_jmx_amd64 +12.99 KiB (0.00% increase) 336.484 → 336.496 → 339.870
docker_agent_jmx_arm64 neutral 319.805 MiB → 324.390
docker_cluster_agent_amd64 +7.59 KiB (0.01% increase) 71.276 → 71.284 → 72.920
docker_cluster_agent_arm64 +4.85 KiB (0.01% increase) 66.920 → 66.925 → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.943 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.272 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.884 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.770 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.895 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.895 MiB → 8.800
iot_agent_deb_amd64 neutral 11.347 MiB → 12.040
iot_agent_deb_arm64 +2.21 KiB (0.02% increase) 9.661 → 9.663 → 10.450
iot_agent_deb_armhf neutral 9.892 MiB → 10.620
iot_agent_rpm_amd64 +2.26 KiB (0.02% increase) 11.365 → 11.368 → 12.060
iot_agent_suse_amd64 +2.26 KiB (0.02% increase) 11.365 → 11.368 → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 16, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a1f0b403-7d8f-4399-9fa5-4877c6f70caf

Baseline: b76b0b9
Comparison: d21f277
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.37 [-2.61, +3.36] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.20 [+0.96, +1.44] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.85 [+0.74, +0.96] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.58 [+0.44, +0.73] 1 Logs
docker_containers_cpu % cpu utilization +0.37 [-2.61, +3.36] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.37 [+0.14, +0.59] 1 Logs
otlp_ingest_metrics memory utilization +0.23 [+0.08, +0.38] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.08, +0.17] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.10 [+0.04, +0.16] 1 Logs
quality_gate_logs % cpu utilization +0.08 [-1.50, +1.65] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.07 [-0.11, +0.26] 1 Logs
docker_containers_memory memory utilization +0.06 [-0.01, +0.14] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.42, +0.45] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.16, +0.17] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.37, +0.38] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.19, +0.18] 1 Logs
quality_gate_idle_all_features memory utilization -0.01 [-0.05, +0.02] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.09, +0.06] 1 Logs
ddot_metrics_sum_delta memory utilization -0.02 [-0.20, +0.15] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.50, +0.39] 1 Logs
otlp_ingest_logs memory utilization -0.22 [-0.32, -0.12] 1 Logs
ddot_logs memory utilization -0.28 [-0.34, -0.22] 1 Logs
file_tree memory utilization -0.34 [-0.39, -0.28] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 709 ≥ 26
docker_containers_memory memory_usage 10/10 270.99MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 732 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.68MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 489.51MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 203.31MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 354.39 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 425.39MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@ajgajg1134 ajgajg1134 changed the title temp commit to hide tagger OriginDetection in non-containers APM: Avoid container ID resolution in non-container envs Mar 18, 2026
@dd-octo-sts dd-octo-sts bot added the team/opentelemetry OpenTelemetry team label Mar 18, 2026
@ajgajg1134 ajgajg1134 changed the title APM: Avoid container ID resolution in non-container envs APM: Avoid container ID resolution in non-container envs (APMS-18824) Mar 18, 2026
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed short review PR is simple enough to be reviewed quickly labels Mar 18, 2026
@ajgajg1134 ajgajg1134 added the qa/done QA done before merge and regressions are covered by tests label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent team/opentelemetry OpenTelemetry team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants