Skip to content

Use zstd for faster compression in e2e test binaries#47973

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
kfairise/zstd-pre-built-e2e-tests
Mar 18, 2026
Merged

Use zstd for faster compression in e2e test binaries#47973
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
kfairise/zstd-pre-built-e2e-tests

Conversation

@KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Mar 18, 2026

What does this PR do?

Change compression for pre-build artifacts to zstd. Making compression time from around 10 minutes to 30 seconds
The compressed package is also around 10% smaller

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Mar 18, 2026
@github-actions github-actions bot added the medium review PR review might take time label Mar 18, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 18, 2026

Gitlab CI Configuration Changes

Modified Jobs

go_e2e_test_binaries
  go_e2e_test_binaries:
    artifacts:
      expire_in: 1 week
      paths:
-     - test-binaries.tar.gz
?                         -
+     - test-binaries.tar.zst
?                          ++
      - manifest.json
    before_script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_e2e.tar.xz
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
    needs:
    - go_e2e_deps
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - pushd test/new-e2e
    - go install github.com/DataDog/orchestrion
    - popd
    - dda inv -- -e new-e2e-tests.build-binaries --output-dir test-binaries -p $KUBERNETES_CPU_REQUEST
      --manifest-file-path manifest.json
-   - tar czf test-binaries.tar.gz test-binaries
?          -                    -
+   - tar -cf test-binaries.tar.zst -I "zstd -T0" test-binaries
?         +                      ++++++++++++++++
    stage: binary_build
    tags:
    - arch:amd64
    - specific:true
    variables:
      KUBERNETES_CPU_REQUEST: 4
      KUBERNETES_MEMORY_LIMIT: 64Gi
      KUBERNETES_MEMORY_REQUEST: 64Gi

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 18, 2026

Files inventory check summary

File checks results against ancestor ffec0a4a:

Results for datadog-agent_7.78.0~devel.git.687.4273c05.pipeline.103310909-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 18, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ffec0a4
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 748.919 MiB
agent_deb_amd64_fips 707.285 MiB
agent_heroku_amd64 312.824 MiB
agent_msi 602.498 MiB
agent_rpm_amd64 748.903 MiB
agent_rpm_amd64_fips 707.268 MiB
agent_rpm_arm64 727.414 MiB
agent_rpm_arm64_fips 688.726 MiB
agent_suse_amd64 748.903 MiB
agent_suse_amd64_fips 707.268 MiB
agent_suse_arm64 727.414 MiB
agent_suse_arm64_fips 688.726 MiB
docker_agent_amd64 809.250 MiB
docker_agent_arm64 812.563 MiB
docker_agent_jmx_amd64 1000.165 MiB
docker_agent_jmx_arm64 992.257 MiB
docker_cluster_agent_amd64 203.688 MiB
docker_cluster_agent_arm64 218.167 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.207 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.847 MiB
dogstatsd_deb_arm64 28.003 MiB
dogstatsd_rpm_amd64 29.847 MiB
dogstatsd_suse_amd64 29.847 MiB
iot_agent_deb_amd64 43.065 MiB
iot_agent_deb_arm64 40.124 MiB
iot_agent_deb_armhf 40.860 MiB
iot_agent_rpm_amd64 43.066 MiB
iot_agent_suse_amd64 43.066 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +46.85 KiB (0.03% increase) 174.181 → 174.227 → 177.700
agent_deb_amd64_fips +18.33 KiB (0.01% increase) 165.178 → 165.196 → 172.230
agent_heroku_amd64 +4.04 KiB (0.01% increase) 74.896 → 74.900 → 79.970
agent_msi -4.0 KiB (0.00% reduction) 137.715 → 137.711 → 146.220
agent_rpm_amd64 -37.16 KiB (0.02% reduction) 177.161 → 177.125 → 180.780
agent_rpm_amd64_fips -12.79 KiB (0.01% reduction) 167.173 → 167.160 → 173.370
agent_rpm_arm64 +10.71 KiB (0.01% increase) 159.622 → 159.633 → 161.610
agent_rpm_arm64_fips +10.03 KiB (0.01% increase) 151.227 → 151.237 → 155.910
agent_suse_amd64 -37.16 KiB (0.02% reduction) 177.161 → 177.125 → 180.780
agent_suse_amd64_fips -12.79 KiB (0.01% reduction) 167.173 → 167.160 → 173.370
agent_suse_arm64 +10.71 KiB (0.01% increase) 159.622 → 159.633 → 161.610
agent_suse_arm64_fips +10.03 KiB (0.01% increase) 151.227 → 151.237 → 155.910
docker_agent_amd64 neutral 267.205 MiB → 271.240
docker_agent_arm64 neutral 254.477 MiB → 259.800
docker_agent_jmx_amd64 neutral 335.847 MiB → 339.870
docker_agent_jmx_arm64 +2.2 KiB (0.00% increase) 319.102 → 319.104 → 324.390
docker_cluster_agent_amd64 neutral 71.289 MiB → 72.920
docker_cluster_agent_arm64 neutral 66.926 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.155 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.478 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.887 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.772 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.897 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.897 MiB → 8.800
iot_agent_deb_amd64 neutral 11.348 MiB → 12.040
iot_agent_deb_arm64 neutral 9.665 MiB → 10.450
iot_agent_deb_armhf neutral 9.896 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.366 MiB → 12.060
iot_agent_suse_amd64 neutral 11.366 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 18, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e7b2c2f6-f0ef-45a5-8810-5373449c22e6

Baseline: 2d29ddd
Comparison: 4273c05
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.17 [-2.82, +3.16] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +2.65 [+2.53, +2.78] 1 Logs
ddot_logs memory utilization +0.50 [+0.43, +0.56] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.28 [+0.14, +0.42] 1 Logs
docker_containers_cpu % cpu utilization +0.17 [-2.82, +3.16] 1 Logs
quality_gate_idle memory utilization +0.14 [+0.09, +0.19] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.13 [-0.11, +0.37] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.13 [-0.05, +0.30] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.07 [-0.16, +0.30] 1 Logs
otlp_ingest_logs memory utilization +0.06 [-0.03, +0.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.38, +0.48] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.18, +0.21] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.07, +0.07] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.20, +0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.40, +0.37] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.02 [-0.08, +0.04] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.51, +0.41] 1 Logs
file_tree memory utilization -0.05 [-0.11, +0.00] 1 Logs
ddot_metrics memory utilization -0.24 [-0.42, -0.06] 1 Logs
docker_containers_memory memory utilization -0.27 [-0.34, -0.20] 1 Logs
quality_gate_idle_all_features memory utilization -0.28 [-0.31, -0.24] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.35 [-1.92, +1.22] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.42 [-0.58, -0.26] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 714 ≥ 26
docker_containers_memory memory_usage 10/10 273.18MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 740 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.77MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 496.72MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 202.89MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 361.71 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 408.03MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@KevinFairise2 KevinFairise2 force-pushed the kfairise/zstd-pre-built-e2e-tests branch from c013fb7 to 4273c05 Compare March 18, 2026 16:00
@KevinFairise2 KevinFairise2 added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 18, 2026
@KevinFairise2 KevinFairise2 marked this pull request as ready for review March 18, 2026 16:55
@KevinFairise2 KevinFairise2 requested review from a team as code owners March 18, 2026 16:55
@KevinFairise2 KevinFairise2 changed the title Try to use zstd for faster compression Use zstd for faster compression in e2e test binaries Mar 18, 2026
Copy link
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had #47396 I think I'll still be able to apply it once yours is merged

@KevinFairise2
Copy link
Member Author

Oh did not realize it was also covering that e2e binaries part :o

@KevinFairise2
Copy link
Member Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 18, 2026

View all feedbacks in Devflow UI.

2026-03-18 17:46:09 UTC ℹ️ Start processing command /merge


2026-03-18 17:46:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-03-18 18:04:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-03-18 18:41:33 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 685ae73 into main Mar 18, 2026
486 of 488 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the kfairise/zstd-pre-built-e2e-tests branch March 18, 2026 18:41
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants