Skip to content

Add explicit cc_static_library import for Bazel 9#47982

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/prereq-cc-static-library-load
Mar 18, 2026
Merged

Add explicit cc_static_library import for Bazel 9#47982
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/prereq-cc-static-library-load

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Mar 18, 2026

What does this PR do?

Adds an explicit load for cc_static_library from @rules_cc//cc:cc_static_library.bzl to rtloader/BUILD.bazel.

Motivation

In Bazel 9, cc_static_library is no longer auto-loaded from Bazel's native namespace:

ERROR: Traceback (most recent call last):
	File "rtloader/BUILD.bazel", line 77, column 18, in <toplevel>
		cc_static_library(
	File "/virtual_builtins_bzl/bazel/exports.bzl", line 40, column 9, in _removed_rule_failure
Error in fail: 
         This rule has been removed from Bazel. Please add a `load()` statement for it.
         This can also be done automatically by running:
         buildifier --lint=fix <path-to-BUILD-or-bzl-file>

The rule was migrated out of Bazel's built-ins into rules_cc, but cc_static_library was not added to its defs.bzl, apparently by omission; it must therefore be loaded explicitly from @rules_cc//cc:cc_static_library.bzl.

The load is transparent on Bazel 8, where the rule would still be auto-loaded, so this change is safe to land before the Bazel 9 upgrade.

Describe how you validated your changes

bazel test //rtloader/... passes.

### What does this PR do?
Adds an explicit `load` for `cc_static_library` from
`@rules_cc//cc:cc_static_library.bzl` to `rtloader/BUILD.bazel`.

### Motivation
In Bazel 9, `cc_static_library` is no longer auto-loaded from Bazel's
native namespace (bazelbuild/rules_cc@2b15b96). The rule was migrated
out of Bazel's built-ins into `rules_cc`, where each migrated rule got
its own dedicated `.bzl` file. `cc_static_library` was not added to
`defs.bzl`, apparently by omission. The rule must therefore be loaded
explicitly from `@rules_cc//cc:cc_static_library.bzl`.

The `load` is transparent on Bazel 8, where the rule would still be auto-loaded,
so this change is safe to land before the Bazel 9 upgrade.

### Describe how you validated your changes
`bazel test //rtloader/...` passes.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 18, 2026
@rdesgroppes rdesgroppes changed the title Add explicit load of cc_static_library for Bazel 9 Add explicit cc_static_library import for Bazel 9 Mar 18, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 18, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 18, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review March 18, 2026 13:21
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 18, 2026 13:21
@agent-platform-auto-pr
Copy link
Contributor

Files inventory check summary

File checks results against ancestor d4c34bbf:

Results for datadog-agent_7.78.0~devel.git.679.459757e.pipeline.103261679-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d4c34bb
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 748.899 MiB
agent_deb_amd64_fips 707.261 MiB
agent_heroku_amd64 312.820 MiB
agent_msi 602.490 MiB
agent_rpm_amd64 748.883 MiB
agent_rpm_amd64_fips 707.244 MiB
agent_rpm_arm64 727.394 MiB
agent_rpm_arm64_fips 688.706 MiB
agent_suse_amd64 748.883 MiB
agent_suse_amd64_fips 707.244 MiB
agent_suse_arm64 727.394 MiB
agent_suse_arm64_fips 688.706 MiB
docker_agent_amd64 809.230 MiB
docker_agent_arm64 812.543 MiB
docker_agent_jmx_amd64 1000.145 MiB
docker_agent_jmx_arm64 992.237 MiB
docker_cluster_agent_amd64 203.680 MiB
docker_cluster_agent_arm64 218.167 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.199 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.843 MiB
dogstatsd_deb_arm64 27.995 MiB
dogstatsd_rpm_amd64 29.843 MiB
dogstatsd_suse_amd64 29.843 MiB
iot_agent_deb_amd64 43.065 MiB
iot_agent_deb_arm64 40.124 MiB
iot_agent_deb_armhf 40.860 MiB
iot_agent_rpm_amd64 43.066 MiB
iot_agent_suse_amd64 43.066 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -8.11 KiB (0.00% reduction) 174.215 → 174.207 → 177.700
agent_deb_amd64_fips -7.54 KiB (0.00% reduction) 165.162 → 165.154 → 172.230
agent_heroku_amd64 -3.81 KiB (0.00% reduction) 74.902 → 74.898 → 79.970
agent_msi +24.0 KiB (0.02% increase) 137.707 → 137.730 → 146.220
agent_rpm_amd64 neutral 177.098 MiB → 180.780
agent_rpm_amd64_fips +3.13 KiB (0.00% increase) 167.168 → 167.172 → 173.370
agent_rpm_arm64 -70.6 KiB (0.04% reduction) 159.669 → 159.600 → 161.610
agent_rpm_arm64_fips +3.98 KiB (0.00% increase) 151.255 → 151.259 → 155.910
agent_suse_amd64 neutral 177.098 MiB → 180.780
agent_suse_amd64_fips +3.13 KiB (0.00% increase) 167.168 → 167.172 → 173.370
agent_suse_arm64 -70.6 KiB (0.04% reduction) 159.669 → 159.600 → 161.610
agent_suse_arm64_fips +3.98 KiB (0.00% increase) 151.255 → 151.259 → 155.910
docker_agent_amd64 neutral 267.193 MiB → 271.240
docker_agent_arm64 neutral 254.485 MiB → 259.800
docker_agent_jmx_amd64 -2.65 KiB (0.00% reduction) 335.840 → 335.838 → 339.870
docker_agent_jmx_arm64 neutral 319.123 MiB → 324.390
docker_cluster_agent_amd64 neutral 71.289 MiB → 72.920
docker_cluster_agent_arm64 neutral 66.927 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.151 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.479 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.884 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.770 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.895 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.895 MiB → 8.800
iot_agent_deb_amd64 neutral 11.350 MiB → 12.040
iot_agent_deb_arm64 +2.62 KiB (0.03% increase) 9.666 → 9.668 → 10.450
iot_agent_deb_armhf neutral 9.894 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.369 MiB → 12.060
iot_agent_suse_amd64 neutral 11.369 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 18, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2c88e838-e2d0-4fa7-beec-2cbb139b1545

Baseline: a7599ec
Comparison: 50d9813
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.70 [-0.38, +5.77] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.70 [-0.38, +5.77] 1 Logs
quality_gate_metrics_logs memory utilization +0.81 [+0.58, +1.04] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.67 [-0.93, +2.28] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.62 [+0.49, +0.75] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.36 [+0.31, +0.42] 1 Logs
otlp_ingest_metrics memory utilization +0.25 [+0.10, +0.41] 1 Logs
file_tree memory utilization +0.11 [+0.05, +0.16] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.07, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.10, +0.10] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.21, +0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.39, +0.38] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.19] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.48, +0.47] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.45, +0.43] 1 Logs
otlp_ingest_logs memory utilization -0.04 [-0.14, +0.05] 1 Logs
quality_gate_idle_all_features memory utilization -0.09 [-0.13, -0.05] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.10 [-0.27, +0.08] 1 Logs
ddot_metrics_sum_delta memory utilization -0.14 [-0.31, +0.03] 1 Logs
ddot_logs memory utilization -0.21 [-0.28, -0.14] 1 Logs
docker_containers_memory memory utilization -0.22 [-0.29, -0.14] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.31, -0.21] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.29 [-0.43, -0.15] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.43 [-0.66, -0.21] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 697 ≥ 26
docker_containers_memory memory_usage 10/10 276.82MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 724 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.58MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 489.36MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 202.09MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 356.60 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 413.71MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 50d9813 into main Mar 18, 2026
302 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/prereq-cc-static-library-load branch March 18, 2026 16:15
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants