Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b8579ec0c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| var buildInfo = component.BuildInfo{ | ||
| Version: "v0.147.0", | ||
| Version: "v0.148.0", |
There was a problem hiding this comment.
This change bumps buildInfo.Version to v0.148.0, but comp/otelcol/collector-contrib/impl/components.go still contains v0.147.0 entries across the ExtensionModules/ReceiverModules/ExporterModules/ProcessorModules/ConnectorModules maps (for example, zpagesextension and debugexporter). That leaves the collector reporting stale component-module versions after the upgrade, which makes status/debug version metadata inaccurate for troubleshooting and audits. Please regenerate components.go alongside the dependency bump so these embedded module versions match 0.148.
Useful? React with 👍 / 👎.
Contributor
Go Package Import DifferencesBaseline: 50d9813
|
chouetz
approved these changes
Mar 18, 2026
Contributor
Files inventory check summaryFile checks results against ancestor ffec0a4a: Results for datadog-agent_7.78.0~devel.git.693.4502c75.pipeline.103320401-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
15 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ffec0a4 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.22 | [-3.23, +2.79] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | ddot_metrics_sum_delta | memory utilization | +3.02 | [+2.84, +3.20] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +3.00 | [+2.85, +3.16] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +2.97 | [+2.79, +3.15] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +1.89 | [+1.66, +2.12] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.43 | [+1.29, +1.56] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +1.21 | [+1.05, +1.37] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.93 | [+0.83, +1.02] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.90 | [+0.84, +0.96] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.32 | [+0.27, +0.37] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.24 | [-1.35, +1.82] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.16 | [+0.11, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.10 | [+0.04, +0.16] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.37, +0.50] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.10, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.19, +0.20] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.51, +0.49] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.42, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.11, +0.04] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.06 | [-0.14, +0.01] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.22 | [-3.23, +2.79] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.32 | [-0.35, -0.28] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.43 | [-0.66, -0.19] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 693 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 277.61MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 718 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.88MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 2 ≤ 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 490.66MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 204.35MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 347.17 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 406.59MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
RiantZ
added
changelog/no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadogfrom v0.147.0 to v0.148.0go.opentelemetry.io/collector/*packages accordinglygithub.com/aws/aws-sdk-go-v2and related packages to latest patch versionsgithub.com/miekg/dnsfrom v1.1.69 to v1.1.72buildInfo.Versionincomp/otelcol/collector/impl/collector.gotov0.148.0Test plan
agentbinary builds successfullyotel-agentbinary builds successfullycomp/otelcol/otlp,otlp/configcheck,otlp/internal/configutils,collector/impl-pipelinetests passcomp/core/agenttelemetry/impltests pass (40 tests)comp/otelcol/otlp/integrationtest— pre-existing timeout failure unrelated to this bump (reproduces on previous commit too)🤖 Generated with Claude Code