Skip to content

reference tables: remove duplicate sync_enabled field #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reference tables: remove duplicate sync_enabled field #3262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38611,7 +38611,6 @@ components:
type: STRING
primary_keys:
- id
sync_enabled: false
tags:
- test_tag
type: reference_table
Expand Down Expand Up @@ -38643,10 +38642,6 @@ components:
$ref: '#/components/schemas/PatchTableRequestDataAttributesFileMetadata'
schema:
$ref: '#/components/schemas/PatchTableRequestDataAttributesSchema'
sync_enabled:
description: Whether this table is synced automatically.
example: false
type: boolean
tags:
description: Tags for organizing and filtering reference tables.
example:
Expand Down
1 change: 0 additions & 1 deletion examples/v2/reference-tables/UpdateReferenceTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public static void main(String[] args) {
.name("name")
.type(ReferenceTableSchemaFieldType.STRING)))
.primaryKeys(Collections.singletonList("id")))
.syncEnabled(false)
.tags(Collections.singletonList("test_tag")))
.type(PatchTableRequestDataType.REFERENCE_TABLE));

Expand Down
29 changes: 1 addition & 28 deletions src/main/java/com/datadog/api/client/v2/model/PatchTableRequestDataAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
PatchTableRequestDataAttributes.JSON_PROPERTY_DESCRIPTION,
PatchTableRequestDataAttributes.JSON_PROPERTY_FILE_METADATA,
PatchTableRequestDataAttributes.JSON_PROPERTY_SCHEMA,
PatchTableRequestDataAttributes.JSON_PROPERTY_SYNC_ENABLED,
PatchTableRequestDataAttributes.JSON_PROPERTY_TAGS
})
@jakarta.annotation.Generated(
Expand All @@ -39,9 +38,6 @@ public class PatchTableRequestDataAttributes {
public static final String JSON_PROPERTY_SCHEMA = "schema";
private PatchTableRequestDataAttributesSchema schema;

public static final String JSON_PROPERTY_SYNC_ENABLED = "sync_enabled";
private Boolean syncEnabled;

public static final String JSON_PROPERTY_TAGS = "tags";
private List<String> tags = null;

Expand Down Expand Up @@ -112,27 +108,6 @@ public void setSchema(PatchTableRequestDataAttributesSchema schema) {
this.schema = schema;
}

public PatchTableRequestDataAttributes syncEnabled(Boolean syncEnabled) {
this.syncEnabled = syncEnabled;
return this;
}

/**
* Whether this table is synced automatically.
*
* @return syncEnabled
*/
@jakarta.annotation.Nullable
@JsonProperty(JSON_PROPERTY_SYNC_ENABLED)
@JsonInclude(value = JsonInclude.Include.USE_DEFAULTS)
public Boolean getSyncEnabled() {
return syncEnabled;
}

public void setSyncEnabled(Boolean syncEnabled) {
this.syncEnabled = syncEnabled;
}

public PatchTableRequestDataAttributes tags(List<String> tags) {
this.tags = tags;
return this;
Expand Down Expand Up @@ -222,15 +197,14 @@ public boolean equals(Object o) {
return Objects.equals(this.description, patchTableRequestDataAttributes.description)
&& Objects.equals(this.fileMetadata, patchTableRequestDataAttributes.fileMetadata)
&& Objects.equals(this.schema, patchTableRequestDataAttributes.schema)
&& Objects.equals(this.syncEnabled, patchTableRequestDataAttributes.syncEnabled)
&& Objects.equals(this.tags, patchTableRequestDataAttributes.tags)
&& Objects.equals(
this.additionalProperties, patchTableRequestDataAttributes.additionalProperties);
}

@Override
public int hashCode() {
return Objects.hash(description, fileMetadata, schema, syncEnabled, tags, additionalProperties);
return Objects.hash(description, fileMetadata, schema, tags, additionalProperties);
}

@Override
Expand All @@ -240,7 +214,6 @@ public String toString() {
sb.append(" description: ").append(toIndentedString(description)).append("\n");
sb.append(" fileMetadata: ").append(toIndentedString(fileMetadata)).append("\n");
sb.append(" schema: ").append(toIndentedString(schema)).append("\n");
sb.append(" syncEnabled: ").append(toIndentedString(syncEnabled)).append("\n");
sb.append(" tags: ").append(toIndentedString(tags)).append("\n");
sb.append(" additionalProperties: ")
.append(toIndentedString(additionalProperties))
Expand Down
4 changes: 2 additions & 2 deletions src/test/resources/com/datadog/api/client/v2/api/reference_tables.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,14 @@ Feature: Reference Tables
Scenario: Update reference table returns "Bad Request" response
Given new "UpdateReferenceTable" request
And request contains "id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "sync_enabled": false, "tags": ["test_tag"]}, "type": "reference_table"}}
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "tags": ["test_tag"]}, "type": "reference_table"}}
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/redapl-experiences
Scenario: Update reference table returns "OK" response
Given new "UpdateReferenceTable" request
And request contains "id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "sync_enabled": false, "tags": ["test_tag"]}, "type": "reference_table"}}
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "tags": ["test_tag"]}, "type": "reference_table"}}
When the request is sent
Then the response status is 200 OK
Loading