Skip to content

Security Monitoring - Fix payload of Validation Endpoint for Suppressions #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Security Monitoring - Fix payload of Validation Endpoint for Suppressions #2815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64883,7 +64883,7 @@ paths:
content:
application/json:
schema:
$ref: '#/components/schemas/SecurityMonitoringSuppressionUpdateRequest'
$ref: '#/components/schemas/SecurityMonitoringSuppressionCreateRequest'
required: true
responses:
'204':
Expand Down
20 changes: 10 additions & 10 deletions examples/v2/security-monitoring/ValidateSecurityMonitoringSuppression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@

from datadog_api_client import ApiClient, Configuration
from datadog_api_client.v2.api.security_monitoring_api import SecurityMonitoringApi
from datadog_api_client.v2.model.security_monitoring_suppression_type import SecurityMonitoringSuppressionType
from datadog_api_client.v2.model.security_monitoring_suppression_update_attributes import (
SecurityMonitoringSuppressionUpdateAttributes,
from datadog_api_client.v2.model.security_monitoring_suppression_create_attributes import (
SecurityMonitoringSuppressionCreateAttributes,
)
from datadog_api_client.v2.model.security_monitoring_suppression_update_data import (
SecurityMonitoringSuppressionUpdateData,
from datadog_api_client.v2.model.security_monitoring_suppression_create_data import (
SecurityMonitoringSuppressionCreateData,
)
from datadog_api_client.v2.model.security_monitoring_suppression_update_request import (
SecurityMonitoringSuppressionUpdateRequest,
from datadog_api_client.v2.model.security_monitoring_suppression_create_request import (
SecurityMonitoringSuppressionCreateRequest,
)
from datadog_api_client.v2.model.security_monitoring_suppression_type import SecurityMonitoringSuppressionType

body = SecurityMonitoringSuppressionUpdateRequest(
data=SecurityMonitoringSuppressionUpdateData(
attributes=SecurityMonitoringSuppressionUpdateAttributes(
body = SecurityMonitoringSuppressionCreateRequest(
data=SecurityMonitoringSuppressionCreateData(
attributes=SecurityMonitoringSuppressionCreateAttributes(
data_exclusion_query="source:cloudtrail account_id:12345",
description="This rule suppresses low-severity signals in staging environments.",
enabled=True,
Expand Down
6 changes: 3 additions & 3 deletions src/datadog_api_client/v2/api/security_monitoring_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,7 +2082,7 @@ def __init__(self, api_client=None):
params_map={
"body": {
"required": True,
"openapi_types": (SecurityMonitoringSuppressionUpdateRequest,),
"openapi_types": (SecurityMonitoringSuppressionCreateRequest,),
"location": "body",
},
},
Expand Down Expand Up @@ -4232,13 +4232,13 @@ def validate_security_monitoring_rule(

def validate_security_monitoring_suppression(
self,
body: SecurityMonitoringSuppressionUpdateRequest,
body: SecurityMonitoringSuppressionCreateRequest,
) -> None:
"""Validate a suppression rule.

Validate a suppression rule.

:type body: SecurityMonitoringSuppressionUpdateRequest
:type body: SecurityMonitoringSuppressionCreateRequest
:rtype: None
"""
kwargs: Dict[str, Any] = {}
Expand Down
2 changes: 1 addition & 1 deletion ...ettes/test_scenarios/test_validate_a_suppression_rule_returns_bad_request_response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-09-01T21:36:42.334Z
2025-09-04T08:33:38.344Z
5 changes: 2 additions & 3 deletions ...ssettes/test_scenarios/test_validate_a_suppression_rule_returns_bad_request_response.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
interactions:
- request:
body: '{"data":{"attributes":{"data_exclusion_query":"not enough attributes"},"type":"suppressions"}}'
body: '{"data":{"attributes":{"data_exclusion_query":"not enough attributes","enabled":false,"name":"cold_harbour","rule_query":"rule:[A-Invalid"},"type":"suppressions"}}'
headers:
accept:
- '*/*'
Expand All @@ -11,8 +11,7 @@ interactions:
response:
body:
string: '{"errors":["input_validation_error(Field ''data.attributes.rule_query''
is invalid: field ''rule_query'' is required)","input_validation_error(Field
''data.attributes.name'' is invalid: name cannot be empty)"]}'
is invalid: rule query is invalid)"]}'
headers:
content-type:
- application/json
Expand Down
2 changes: 1 addition & 1 deletion tests/v2/features/security_monitoring.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ Feature: Security Monitoring
@team:DataDog/k9-cloud-security-platform
Scenario: Validate a suppression rule returns "Bad Request" response
Given new "ValidateSecurityMonitoringSuppression" request
And body with value {"data": {"attributes": {"data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
And body with value {"data": {"attributes": {"name" : "cold_harbour", "enabled": false, "rule_query":"rule:[A-Invalid", "data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
When the request is sent
Then the response status is 400 Bad Request

Expand Down
Loading