Revert the earlier spelling change #2096
Conversation
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| if (value = attributes[:'principal']).is_a?(Array) | ||
| self.principal = value | ||
| if attributes.key?(:'principals') | ||
| if (value = attributes[:'principals']).is_a?(Array) |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider using Array() to ensure the type is that of an array (...read more)
The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.
The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.
By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.
* Regenerate client from commit 67b7e114 of spec repo * pre-commit fixes * pre-commit fixes * pre-commit fixes * pre-commit fixes --------- Co-authored-by: ci.datadog-api-spec <[email protected]> Co-authored-by: amaskara-dd <[email protected]> abf60e2
See DataDog/datadog-api-spec#3308
Test branch datadog-api-spec/test/teodor.todorov/SYNTH-13677/fix-spelling-error-for-bindings-again