-
Notifications
You must be signed in to change notification settings - Fork 21
Sync OpenAPI specification for (spec-v1-synthetics.yaml) #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync OpenAPI specification for (spec-v1-synthetics.yaml) #2214
Conversation
|
|
||
| # auth_names | ||
| auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth, :AuthZ] | ||
| auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth, :AuthZ, :AuthZ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Code Quality Violation
| auth_names = opts[:debug_auth_names] || [:apiKeyAuth, :appKeyAuth, :AuthZ, :AuthZ] | |
| auth_names = opts[:debug_auth_names] || %i[apiKeyAuth appKeyAuth AuthZ AuthZ] |
Consider using the %i syntax instead (...read more)
The rule "Prefer %i to the literal array syntax" is a guideline that encourages the use of the %i syntax for arrays of symbols. This is a part of the Ruby style guide that aims to promote conciseness and readability.
Symbols are immutable, reusable objects often used in Ruby instead of strings when the value does not need to be changed. When declaring an array of symbols, using the %i syntax can make your code cleaner and easier to read.
To adhere to this rule, instead of declaring an array of symbols using the literal array syntax like [:foo, :bar, :baz], use the %i syntax like %i[foo bar baz]. It's a good practice to consistently use %i for arrays of symbols as it enhances code readability and maintainability.
Datadog ReportBranch report: ✅ 0 Failed, 1115 Passed, 2089 Skipped, 1m 51.45s Total duration (1m 23.54s time saved) |
12c7976 to
75b01a6
Compare
75b01a6 to
9cb86b4
Compare
26942e4 to
edf307f
Compare
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
edf307f to
961075f
Compare
961075f to
723a422
Compare
723a422 to
b65d2b3
Compare
b65d2b3 to
d5baf12
Compare
d5baf12 to
d119e03
Compare
db0c013 to
c994a9c
Compare
dd87adc to
6c6fe49
Compare
6c6fe49 to
22cde49
Compare
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
See DataDog/datadog-api-spec#3452 Test branch datadog-api-spec/test/sync-forwarder-specs/488ea684536e2f3b4cb32e40f64e791c-spec-v1-synthetics.yaml