Skip to content

Conversation

@api-clients-generation-pipeline
Copy link
Contributor

end

if attributes.key?(:'embeddable_domains')
if (value = attributes[:'embeddable_domains']).is_a?(Array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Consider using Array() to ensure the type is that of an array (...read more)

The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.

The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.

By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.

View in Datadog  Leave us feedback  Documentation

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 21, 2025

Datadog Report

Branch report: datadog-api-spec/generated/3565
Commit report: 2eaa9ec
Test service: datadog-api-client-ruby

✅ 0 Failed, 1165 Passed, 1820 Skipped, 1m 53.03s Total Time

@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3565 branch from f09dfa9 to b25efd3 Compare February 21, 2025 22:57
@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3565 branch 5 times, most recently from 89a6f9d to 3bada28 Compare February 25, 2025 14:52
@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3565 branch from 3bada28 to 3dcee13 Compare February 25, 2025 17:20
@api-clients-generation-pipeline api-clients-generation-pipeline bot merged commit f61a03b into master Feb 25, 2025
16 checks passed
@api-clients-generation-pipeline api-clients-generation-pipeline bot deleted the datadog-api-spec/generated/3565 branch February 25, 2025 18:27
github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants