Skip to content

Conversation

@api-clients-generation-pipeline
Copy link
Contributor

end

if attributes.key?(:'quality_issues')
if (value = attributes[:'quality_issues']).is_a?(Array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Consider using Array() to ensure the type is that of an array (...read more)

The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.

The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.

By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.

View in Datadog  Leave us feedback  Documentation

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: datadog-api-spec/generated/3625
Commit report: 19a911b
Test service: datadog-api-client-ruby

✅ 0 Failed, 1016 Passed, 2008 Skipped, 1m 44.04s Total duration (1m 9.4s time saved)

@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3625 branch 2 times, most recently from 5480fc7 to f7d8835 Compare March 5, 2025 20:43
@api-clients-generation-pipeline api-clients-generation-pipeline bot changed the title [MQI-286] add monitor quality issues to response schema Add quality_issues to monitor schema on monitor search API Mar 5, 2025
@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3625 branch from f7d8835 to d6e1347 Compare March 5, 2025 21:01
@api-clients-generation-pipeline api-clients-generation-pipeline bot merged commit fd3263e into master Mar 5, 2025
14 checks passed
@api-clients-generation-pipeline api-clients-generation-pipeline bot deleted the datadog-api-spec/generated/3625 branch March 5, 2025 22:28
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants