Skip to content

Fix api_instance name with a dash#2398

Merged
NaOHman merged 3 commits intomasterfrom
daniel-m-dd-patch-1
May 9, 2025
Merged

Fix api_instance name with a dash#2398
NaOHman merged 3 commits intomasterfrom
daniel-m-dd-patch-1

Conversation

@daniel-m-dd
Copy link
Contributor

@daniel-m-dd daniel-m-dd commented May 7, 2025

What does this PR do?

Looking at the Ruby example on this documentation page for on-call endpoints, we can see
api_instance = DatadogAPIClient::V2::On - CallAPI.new which is not valid ruby.

This PR fixes the example/instance name to match the generated one (dash stripped)

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.

  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@daniel-m-dd daniel-m-dd requested review from a team as code owners May 7, 2025 06:16
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 7, 2025 •
edited
Loading

Datadog Report

Branch report: daniel-m-dd-patch-1
Commit report: 8162df0
Test service: datadog-api-client-ruby

✅ 0 Failed, 1050 Passed, 2187 Skipped, 1m 53.98s Total duration (1m 20.21s time saved)

@daniel-m-dd
Copy link
Contributor Author

daniel-m-dd commented May 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 7, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-07 23:21:29 UTC ℹ️ Start processing command /merge

2025-05-07 23:21:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-05-08 00:17:16 UTC ⚠️ MergeQueue: This merge request build was cancelled

daniel.marin@datadoghq.com cancelled this merge request build

@daniel-m-dd
Copy link
Contributor Author

daniel-m-dd commented May 8, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented May 8, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-08 00:17:11 UTC ℹ️ Start processing command /remove

2025-05-08 00:17:14 UTC ℹ️ Devflow: /remove

@NaOHman
Copy link
Contributor

NaOHman commented May 8, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 8, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-08 14:01:42 UTC ℹ️ Start processing command /merge

2025-05-08 14:01:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-05-08 16:02:00 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

Possible reasons:

  • some mandatory checkruns are failing:
    • test_integration
  • because of branch restrictions, this PR cannot be merged by the mergequeue app DD-MergeQueue. It can only be merged by teams Web Frameworks Approvers or apps API Clients Generation Pipeline
  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated

@daniel-m-dd
Copy link
Contributor Author

daniel-m-dd commented May 8, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 8, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-08 21:47:50 UTC ℹ️ Start processing command /merge

2025-05-08 21:47:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-05-08 23:46:04 UTC ⚠️ MergeQueue: This merge request build was cancelled

daniel.marin@datadoghq.com cancelled this merge request build

@daniel-m-dd
Copy link
Contributor Author

daniel-m-dd commented May 8, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented May 8, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-08 23:45:59 UTC ℹ️ Start processing command /remove

2025-05-08 23:46:02 UTC ℹ️ Devflow: /remove

@NaOHman NaOHman merged commit 490edd1 into master May 9, 2025
14 checks passed
@NaOHman NaOHman deleted the daniel-m-dd-patch-1 branch May 9, 2025 14:09
github-actions bot pushed a commit that referenced this pull request May 9, 2025
@NaOHman
Fix api_instance name with a dash (#2398)
63f14e6 
* Fix api_instance name with a dash

* pre-commit fixes

---------

Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: Jeffrey <jeffrey.lyman@datadoghq.com> 490edd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NaOHman NaOHman NaOHman approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daniel-m-dd @NaOHman