Skip to content

[AAWF-638] Remove description requirements #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skarimo merged 3 commits into from
Oct 24, 2025
Merged

[AAWF-638] Remove description requirements #2740

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
986fba8
handle missing discription
skarimo Oct 23, 2025
bc7d451
Regenerate client from commit 77596ba of spec repo
Oct 23, 2025
7396ce8
Merge branch 'master' into datadog-api-spec/generated/4516
skarimo Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .generator/schemas/v1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9646,6 +9646,8 @@ components:
type: object
NotebookGlobalTime:
description: Notebook global timeframe.
example:
live_span: 1h
oneOf:
- $ref: '#/components/schemas/NotebookRelativeTime'
- $ref: '#/components/schemas/NotebookAbsoluteTime'
Expand Down Expand Up @@ -14820,6 +14822,7 @@ components:
SyntheticsAssertionTargetValue:
description: Value used by the operator in assertions. Can be either a number
or string.
example: 0.0
oneOf:
- $ref: '#/components/schemas/SyntheticsAssertionTargetValueNumber'
- $ref: '#/components/schemas/SyntheticsAssertionTargetValueString'
Expand Down
4 changes: 4 additions & 0 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,6 +2361,7 @@ components:
- $ref: '#/components/schemas/ActionQueryMockedOutputsObject'
ActionQueryMockedOutputsEnabled:
description: Whether to enable the mocked outputs for testing.
example: false
oneOf:
- type: boolean
- description: If this is a string, it must be a valid JavaScript expression
Expand Down Expand Up @@ -2450,6 +2451,7 @@ components:
type: string
ActionQuerySpec:
description: The definition of the action query.
example: ''
oneOf:
- type: string
- $ref: '#/components/schemas/ActionQuerySpecObject'
Expand Down Expand Up @@ -13516,6 +13518,7 @@ components:
type: object
CustomAttributeValuesUnion:
description: Union of supported value for a custom attribute
example: ''
oneOf:
- $ref: '#/components/schemas/CustomAttributeStringValue'
- $ref: '#/components/schemas/CustomAttributeMultiStringValue'
Expand Down Expand Up @@ -33373,6 +33376,7 @@ components:
ObservabilityPipelineOcsfMapperProcessorMappingMapping:
description: Defines a single mapping rule for transforming logs into the OCSF
schema.
example: CloudTrail Account Change
oneOf:
- $ref: '#/components/schemas/ObservabilityPipelineOcsfMappingLibrary'
ObservabilityPipelineOcsfMapperProcessorType:
Expand Down
2 changes: 1 addition & 1 deletion .generator/src/generator/templates/model.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require 'date'
require 'time'

module {{ module_name }}::{{ version|upper }}
# {{ model.description.rstrip()|replace('\n', '\n# ')|indent(2) }}
# {{ (model.description or "").rstrip()|replace('\n', '\n# ')|indent(2) }}
{%- if model.deprecated %}
#
# @deprecated This model is deprecated.
Expand Down
2 changes: 1 addition & 1 deletion .generator/src/generator/templates/model_generic.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
or
definition.enum is defined #}

{{ definition.description|block_comment|indent(4) }}
{{ (definition.description or "")|block_comment|indent(4) }}
{%- if has_validation %}
attr_reader :{{ attr|attribute_name }}
{%- else %}
Expand Down