-
Notifications
You must be signed in to change notification settings - Fork 16
Convert TypeScript testing workflow to reusable workflow #2763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MintsInc
wants to merge
18
commits into
master
from
ulysse.mavrocordatos/AAWF-562/make-typescript-test-workflow-reusable
Closed
Convert TypeScript testing workflow to reusable workflow #2763
MintsInc
wants to merge
18
commits into
master
from
ulysse.mavrocordatos/AAWF-562/make-typescript-test-workflow-reusable
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
605db6f
to
eca7dbb
Compare
jack-edmonds-dd
approved these changes
Sep 8, 2025
Co-authored-by: ci.datadog-api-spec <[email protected]>
…ting, and filtering params (#2752) Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]> Co-authored-by: Damien Fleurisson <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
#2769) Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Co-authored-by: ci.datadog-api-spec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is the first step in a larger initiative to standardize CI workflows across all Datadog API client repositories. By converting our TypeScript testing workflow to a reusable workflow, we can:
the same testing workflow
This PR serves as a proof-of-concept to validate that the reusable workflow approach works correctly before rolling it out to other client repositories and the specification repo.
This implementation follows the same pattern as the Go client changes in DataDog/datadog-api-client-go#3317.
Changes
New Files
.github/workflows/reusable-typescript-test.yml
: A reusable workflow that contains the same logic as the original test workflowModified Files
.github/workflows/test.yml
: Simplified to call the reusable workflowKey Design Decisions
Tests
This PR maintains identical CI behavior for this repository - same triggers, job matrix, conditional logic, and status reporting. After merging, we'll verify that the workflow is properly triggered on other PRs, then we'll test calling this reusable workflow from the datadog-api-spec repository to verify cross-repository execution and MergeQueue compatibility before rolling out to other client repositories.