feat(bottlecap): add runtime tag
#464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
commented
Nov 21, 2024
Comment on lines
+188
to
+193
|
|
||
| if let Some(runtime) = &self.runtime { | ||
| self.span | ||
| .meta | ||
| .insert(String::from("runtime"), runtime.to_string()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Not sure if we actually need this, it looks like previous versions have the runtime tag in spans, but not sure if this is done in backend or tracer.
duncanista
commented
Nov 21, 2024
|
|
||
| // Resolve runtime only once | ||
| let runtime = resolve_runtime_from_proc(PROC_PATH, ETC_PATH); | ||
| self.enhanced_metrics.set_runtime_tag(&runtime); |
Contributor
Author
There was a problem hiding this comment.
This is definitely needed tho
bottlecap/src/tags/lambda/tags.rs
Outdated
| tags_map | ||
| } | ||
|
|
||
| #[allow(dead_code)] // keeping this logic for when async runtime resolution will be supported |
Contributor
There was a problem hiding this comment.
we can remove this now, right?
alexgallotta
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the
runtimetag to the invocation span and metric tags.