Feat: support adaptive flush strategy again #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Nov 26, 2024
duncanista
approved these changes
Nov 26, 2024
alexgallotta
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed this initially as I believed it either wasn't necessary or didn't help much (I think? I had just had a baby)
We've since gotten some feedback that, although users can set
DD_SERVERLESS_FLUSH_STRATEGY=periodically,10000to flush every 10s regardless of the number of invocations, they prefer the automatic adaptive strategy we had earlier.So I'm adding this back