Skip to content

SVLS-6128 fix: set right domain and arn by region on secrets manager #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexgallotta merged 6 commits into from
Jan 15, 2025
Merged

SVLS-6128 fix: set right domain and arn by region on secrets manager #511

alexgallotta merged 6 commits into from
Jan 15, 2025

Conversation

@alexgallotta
Copy link
Contributor

@alexgallotta alexgallotta commented Jan 13, 2025 •
edited
Loading

Addressing bug report #508
SVLS-6128

As per AWS doc https://aws.amazon.com/blogs/enterprise-strategy/getting-started-with-aws-services-in-aws-china-beijing-region-and-aws-china-ningxia-region/ the AWS regions in China have different domain and arn

  • AWS China Regions names are as follows. Beijing: cn-north-1; Ningxia: cn-northwest-1.
  • In AWS China Regions, the Amazon Resource Name (ARN) syntax includes a cn. For example: arn:aws-cn:iam::123456789012:user/division_abc/subdivision_xyz/Bob.

the domain in ARN for the services should be amazonaws.com.cn as per doc
https://docs.amazonaws.cn/en_us/aws/latest/userguide/endpoints-Beijing.html
https://docs.amazonaws.cn/en_us/aws/latest/userguide/endpoints-Ningxia.html

duncanista
duncanista reviewed Jan 14, 2025
View reviewed changes
duncanista
duncanista reviewed Jan 14, 2025
View reviewed changes
burnster
burnster approved these changes Jan 14, 2025
View reviewed changes
Copy link

@burnster burnster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the quick fix.

duncanista
duncanista reviewed Jan 15, 2025
View reviewed changes
duncanista
duncanista approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some nits

@duncanista duncanista changed the title check whether the region is in China and use the appropriated domain fix: set right domain and arn by region on secrets manager Jan 15, 2025
burnster
burnster approved these changes Jan 15, 2025
View reviewed changes
Copy link

@burnster burnster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update to cover all the partitions.

@alexgallotta alexgallotta marked this pull request as ready for review January 15, 2025 19:30
@alexgallotta alexgallotta requested a review from a team as a code owner January 15, 2025 19:30
@alexgallotta alexgallotta merged commit 63c6515 into main Jan 15, 2025
21 of 22 checks passed
@alexgallotta alexgallotta deleted the china-aws-decrypt-domain branch January 15, 2025 19:30
@alexgallotta alexgallotta changed the title fix: set right domain and arn by region on secrets manager SVLS-6128 fix: set right domain and arn by region on secrets manager Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

@astuyve astuyve Awaiting requested review from astuyve

+1 more reviewer

@burnster burnster burnster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexgallotta @burnster @duncanista