Skip to content

fix: traces success response to be Ok instead of Accepted #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyamalpani merged 2 commits into from
Jan 21, 2025
Merged

fix: traces success response to be Ok instead of Accepted #518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
300595a
update traces success response
shreyamalpani Jan 17, 2025
4b47653
format fix
shreyamalpani Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bottlecap/src/traces/trace_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ use tracing::{debug, error};
use crate::config;
use crate::tags::provider;
use crate::traces::{stats_flusher, stats_processor, trace_flusher, trace_processor};
use datadog_trace_mini_agent::http_utils::{self, log_and_create_http_response};
use datadog_trace_mini_agent::http_utils::{
self, log_and_create_http_response, log_and_create_traces_success_http_response,
};
use datadog_trace_protobuf::pb;
use datadog_trace_utils::trace_utils::{self, SendData};

Expand Down Expand Up @@ -263,9 +265,9 @@ impl TraceAgent {

// send trace payload to our trace flusher
match trace_tx.send(send_data).await {
Ok(()) => log_and_create_http_response(
Ok(()) => log_and_create_traces_success_http_response(
"Successfully buffered traces to be flushed.",
StatusCode::ACCEPTED,
StatusCode::OK,
),
Err(err) => log_and_create_http_response(
&format!("Error sending traces to the trace flusher: {err}"),
Expand Down
Loading