fix: licenses #528
Merged
fix: licenses #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Jan 27, 2025
bottlecap/LICENSE-3rdparty.yml
Outdated
| not be used in advertising or otherwise to promote the sale, use or other | ||
| dealings in these Data Files or Software without prior written | ||
| authorization of the copyright holder. | ||
| text: NOT FOUND |
Contributor
There was a problem hiding this comment.
Removing a license 🤔
This bug has been happening for a while, sometimes it gets fixed randomly
Contributor
Author
There was a problem hiding this comment.
The bug is that our CI is installing cargo-bundle-licenses via an unqualified installation command, so it was pulling the latest version, in this case v3.
My local machine had v2.x, so there were some conflicts. Our cache key is perhaps a big ambiguous, but in this case it's passing and the fix was just updating cargo-bundle-licenses on my machine.
duncanista
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the 3rdparty license files