Skip to content

Conversation

@apiarian-datadog
Copy link
Contributor

In preparation for supporting fips builds, let's refactor our gitlab build pipelines to simplify things.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from a6b91b4 to a5620f3 Compare February 12, 2025 15:07
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from c676964 to 2d06d3d Compare February 12, 2025 15:39
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from 2d06d3d to 95d194c Compare February 12, 2025 15:46
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from 5a04819 to 33f0c78 Compare February 12, 2025 15:57
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from 78e3a6a to 6894522 Compare February 13, 2025 21:13
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from 6894522 to 5a813e3 Compare February 13, 2025 21:17
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch from 755170b to 5fcf2bc Compare February 13, 2025 21:50
@apiarian-datadog apiarian-datadog marked this pull request as ready for review February 13, 2025 21:50
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner February 13, 2025 21:50
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NITS – overall, looks great!

Make sure to update the team around the breaking changes on the scripts that this PR introduces

@apiarian-datadog
Copy link
Contributor Author

apiarian-datadog commented Feb 18, 2025

confirmed that the binaries built with these refactored scripts are identical to the ones built on main (the difference in the datadog_wrapper comes from the comment i added in this pr:

➜  ~ find ~/Desktop -type f ! -name ".*" ! -name "*.zip" -print0 | xargs -0 sha256sum | sort
042da5f72e4c6011f24be50c63e5a614db4a21fb8a684baf70033fcd904e6cb9  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64-alpine/datadog-agent-go
042da5f72e4c6011f24be50c63e5a614db4a21fb8a684baf70033fcd904e6cb9  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64-alpine/datadog-agent-go
06ac6f66e9984ef1e74c648633bb2665751876e686b02098e3236ce7f2685fe1  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64/extensions/datadog-agent
06ac6f66e9984ef1e74c648633bb2665751876e686b02098e3236ce7f2685fe1  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64/extensions/datadog-agent
1e9502399ffceed987978c687056f2ac3245d7fabd5f067757f61252ec8052fa  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64/datadog-agent-go
1e9502399ffceed987978c687056f2ac3245d7fabd5f067757f61252ec8052fa  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64/datadog-agent-go
26ea92188bd008766fe70df6d98be35ddd4e14645509ae96a77ed290aa9011e3  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64/datadog-agent-go
26ea92188bd008766fe70df6d98be35ddd4e14645509ae96a77ed290aa9011e3  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64/datadog-agent-go
27be015a134709998b3c7f5428d6bb3431805ed2a3eb6f289d65bbe279d99e57  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64/extensions/datadog-agent
27be015a134709998b3c7f5428d6bb3431805ed2a3eb6f289d65bbe279d99e57  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64/extensions/datadog-agent
47917353cf6500eaf960257212f71797c039b989d86e0767705f1edad05e7a13  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64-alpine/extensions/datadog-agent
47917353cf6500eaf960257212f71797c039b989d86e0767705f1edad05e7a13  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64-alpine/extensions/datadog-agent
762fe547981f7b102c413a2c14050047beb5b21f5819027d05046b33d8769115  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64-alpine/extensions/datadog-agent
762fe547981f7b102c413a2c14050047beb5b21f5819027d05046b33d8769115  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64-alpine/extensions/datadog-agent
a21ce323f49087290d5969a2c275bf333f6b1cb898491963842306a3e07453fc  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64-alpine/datadog_wrapper
a21ce323f49087290d5969a2c275bf333f6b1cb898491963842306a3e07453fc  /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64/datadog_wrapper
a21ce323f49087290d5969a2c275bf333f6b1cb898491963842306a3e07453fc  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64-alpine/datadog_wrapper
a21ce323f49087290d5969a2c275bf333f6b1cb898491963842306a3e07453fc  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64/datadog_wrapper
c604b1335569d9f3eef177a86a8ec0ce2e0326d9ccc8881338296189f69cf337  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64-alpine/datadog-agent-go
c604b1335569d9f3eef177a86a8ec0ce2e0326d9ccc8881338296189f69cf337  /Users/aleksandr.pasechnik/Desktop/datadog_extension-arm64-alpine/datadog-agent-go
dbb66b4d691d5d5f5433cac2c71b2f19e80ea9deb6774851a5bfbe530ba435bf  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64-alpine/datadog_wrapper
dbb66b4d691d5d5f5433cac2c71b2f19e80ea9deb6774851a5bfbe530ba435bf  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-amd64/datadog_wrapper
dbb66b4d691d5d5f5433cac2c71b2f19e80ea9deb6774851a5bfbe530ba435bf  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64-alpine/datadog_wrapper
dbb66b4d691d5d5f5433cac2c71b2f19e80ea9deb6774851a5bfbe530ba435bf  /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64/datadog_wrapper
➜  ~ diff /Users/aleksandr.pasechnik/Desktop/datadog_extension-amd64-alpine/datadog_wrapper /Users/aleksandr.pasechnik/Desktop/datadog_bottlecap-arm64-alpine/datadog_wrapper
2,6d1
<
< # This is a wrapper script that is intended be used in conjunction with the
< # AWS_LAMBDA_EXEC_WRAPPER environment variable on an AWS Lambda function. It
< # enables universal instrumentation support for our Java and .NET runtimes.
<

@apiarian-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 18, 2025

View all feedbacks in Devflow UI.
2025-02-18 16:44:44 UTC ℹ️ Start processing command /merge


2025-02-18 16:44:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-18 16:48:01 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@apiarian-datadog
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Feb 18, 2025

View all feedbacks in Devflow UI.
2025-02-18 16:47:57 UTC ℹ️ Start processing command /remove


2025-02-18 16:47:59 UTC ℹ️ Devflow: /remove

@apiarian-datadog apiarian-datadog merged commit b2e91c0 into main Feb 18, 2025
33 of 34 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-6279-refactor-gitlab-build-pipelines branch February 18, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants