Skip to content

chore: [SVLS-6279] fips-flavored builds #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apiarian-datadog merged 35 commits into from
Mar 20, 2025
Merged

chore: [SVLS-6279] fips-flavored builds #556

apiarian-datadog merged 35 commits into from
Mar 20, 2025

Conversation

@apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Feb 18, 2025 •
edited
Loading

In order to support FIPS flavored go agent builds (added in DataDog/datadog-agent#33799 ) we're making the following changes:

  • refactoring the build pipeline to add fips flavors
  • rearranging the environment datasource to make it a dictionary instead of a list
  • replacing our old publish_govcloud.sh script with a new publish_govcloud_layers.sh script which uses the same publish layers script as the commercial gitlab job

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-try-fips-build branch 18 times, most recently from a02eb63 to fab54e7 Compare February 21, 2025 18:15
apiarian-datadog
apiarian-datadog commented Feb 21, 2025
View reviewed changes
@apiarian-datadog apiarian-datadog marked this pull request as ready for review February 21, 2025 18:20
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner February 21, 2025 18:20
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-try-fips-build branch 8 times, most recently from ce59df9 to 4afc16a Compare February 21, 2025 21:14
apiarian-datadog
apiarian-datadog commented Feb 24, 2025
View reviewed changes
@apiarian-datadog
chore: [SVLS-6279] we expect no goboring for non fips builds
eac2416
@apiarian-datadog
chore: [SVLS-6279] make sure we are fipsing correctly
7820a79
@apiarian-datadog
chore: [SVLS-6279] parametrize and adjust max layer sizes
6c6ae73
@apiarian-datadog
chore: [SVLS-6279] fix build_private_image.sh
c5f688c
@apiarian-datadog
chore: [SVLS-6279] rename WORKFLOW_LAYER_SUFFIX to PIPELINE_LAYER_SUFFIX
de115ec
@apiarian-datadog
chore: [SVLS-6279] rename add_permissions to add_layer_version_permis…
1471b5b 
…sions
@apiarian-datadog
chore: [SVLS-6279] mb layer size for convenience
b26c7c4
@apiarian-datadog
Revert "chore: [SVLS-6279] mb layer size for convenience"
4fc95a3 
This reverts commit e1d4e7d.
@apiarian-datadog
chore: [SVLS-6279] fix layer size limits
3706f68
@apiarian-datadog
chore: [SVLS-6279] fix typos
6f93f75
@apiarian-datadog
chore: [SVLS-6279] production artifacts expire in a day instead of an…
645e193 
… hour
@apiarian-datadog
chore: fix bottlecap compilex
c6f971d
@apiarian-datadog
chore: remove role examples
c1304e5
@apiarian-datadog
chore: we do not have a staging environment
59cb8bc
@apiarian-datadog
chore: environments make more sense as objects instead of a list
354514c
@apiarian-datadog
chore: simplify layer bundling
4f640be
@apiarian-datadog
chore: get rid of most of the environment loops
121165c
@apiarian-datadog
chore: do cargo fmt, check, and clippy only once
16b0dc4
@apiarian-datadog
chore: we do not push fips layers from gitlab but we do check their size
71c1f73
@apiarian-datadog
chore: separate layer signing from layer publishing
4f8da9f
@apiarian-datadog
chore: fix typo
597c330
@apiarian-datadog
chore: fix lyaer size limits
b4396e5
@apiarian-datadog
chore: address review comments
85666ec
@apiarian-datadog
chore: expand signed artifacts to 1 week
a83f4e8
@apiarian-datadog
chore: better VERSION handling for publishing layers
b46e0e8
@apiarian-datadog
chore: use the main branch now that datadog-agent#33799 is merged
0e4b85d
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-6279-try-fips-build branch from 8616379 to 0e4b85d Compare March 20, 2025 19:22
@apiarian-datadog apiarian-datadog merged commit e177d55 into main Mar 20, 2025
45 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-6279-try-fips-build branch March 20, 2025 19:58
@apiarian-datadog apiarian-datadog mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

+2 more reviewers

@alexgallotta alexgallotta alexgallotta left review comments

@nhulston nhulston nhulston left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@apiarian-datadog @alexgallotta @nhulston @duncanista