Skip to content

SVLS-8232: Properly test cold_start attribute in LMI #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
litianningdatadog merged 1 commit into from
Jan 13, 2026
+13 −2
Merged

SVLS-8232: Properly test cold_start attribute in LMI #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions integration-tests/tests/lmi.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,23 @@ describe('LMI Integration Tests', () => {
expect(awsLambdaSpan?.attributes.custom.init_type).toBe('lambda-managed-instances')
})
// SVLS-8232
test.skip('aws.lambda.span should have cold_start set to false', () => {
it('aws.lambda.span should have cold_start set to false if no cold_start operation', () => {
const trace = results[runtime].traces![0];

// The presence of 'aws.lambda.cold_start' span indicates a cold start
const coldStartSpan = trace.spans.find((span: any) =>
span.attributes.operation_name === 'aws.lambda.cold_start'
);

const awsLambdaSpan = trace.spans.find((span: any) =>
span.attributes.operation_name === 'aws.lambda'
);
expect(awsLambdaSpan?.attributes.custom.cold_start).toBe('false')
expect(awsLambdaSpan).toBeDefined(); // Ensure span exists before checking attributes

// Only check cold_start attribute when no dedicated cold_start span exists
if (!coldStartSpan) {
expect(awsLambdaSpan?.attributes.custom.cold_start).toBe('false');
}
})

});
Expand Down
Loading