Skip to content

Conversation

@tbavelier
Copy link
Member

What does this PR do?

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Same as original PR #2367, but verify the lastTransition field gets updated during the progress, and then not anymore once it's complete

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added this to the v1.22.0 milestone Dec 18, 2025
@tbavelier tbavelier added the enhancement New feature or request label Dec 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (7780750) to head (f17b79e).

Files with missing lines Patch % Lines
pkg/agentprofile/agent_profile.go 80.95% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2419      +/-   ##
==========================================
+ Coverage   37.28%   37.32%   +0.03%     
==========================================
  Files         290      290              
  Lines       24710    24720      +10     
==========================================
+ Hits         9213     9226      +13     
+ Misses      14784    14781       -3     
  Partials      713      713              
Flag Coverage Δ
unittests 37.32% <84.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/agentprofile/status.go 67.53% <100.00%> (ø)
pkg/agentprofile/agent_profile.go 74.36% <80.95%> (+1.44%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7780750...f17b79e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier marked this pull request as ready for review December 18, 2025 18:37
@tbavelier tbavelier requested a review from a team as a code owner December 18, 2025 18:37
@tbavelier tbavelier merged commit 490d736 into main Dec 19, 2025
35 checks passed
@tbavelier tbavelier deleted the tbavelier/create-strategy-followup branch December 19, 2025 16:41
dd-octo-sts bot pushed a commit that referenced this pull request Dec 22, 2025
* Preserve createStrategy status and update lastTransition

* Create DAP strategy last transition fill

* small if simplification

* fix tests + duplicate imports

(cherry picked from commit 490d736)
tbavelier added a commit that referenced this pull request Dec 23, 2025
* Preserve createStrategy status and update lastTransition

* Create DAP strategy last transition fill

* small if simplification

* fix tests + duplicate imports

(cherry picked from commit 490d736)

Co-authored-by: Timothée Bavelier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.22 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants