-
Notifications
You must be signed in to change notification settings - Fork 130
[OTAGENT-512] Add more configs and examples to otel agent gateway #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (42.10%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
+ Coverage 38.38% 38.40% +0.02%
==========================================
Files 300 300
Lines 25555 25562 +7
==========================================
+ Hits 9809 9817 +8
+ Misses 15002 15001 -1
Partials 744 744
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
5b56f18 to
81e0cda
Compare
This comment was marked as resolved.
This comment was marked as resolved.
54d666b to
02121d5
Compare
02121d5 to
b4a0cc1
Compare
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the description to "feature gates" would be more readable, but feel free to ignore if there are technical reasons to keep FeatureGates. Thanks!
What does this PR do?
Add config
FeatureGatesto otel agent gateway matching the implementation in helm charts: http://github.com/DataDog/helm-charts/blob/main/charts/datadog/templates/otel-agent-gateway-deployment.yaml.The following configs are already supported with
override, so no need to add them again to otel agent gateway feature:examples/datadogagent/datadog-agent-with-otelagentgateway.yaml shows an example of setting all the fields above (and many others) for otel agent gateway.
Motivation
Implement otel agent gateway in operator.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
For QA, use examples/datadogagent/datadog-agent-with-otelagentgateway.yaml. You can uncomment / tweak the parameters based on your needs. Verify the node selector, affinity, labels, replicas etc. in the otel agent gateway deployment and pods are expected.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel