-
Notifications
You must be signed in to change notification settings - Fork 131
[ACTP] add private action runner to datadog operator #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ACTP] add private action runner to datadog operator #2516
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
+ Coverage 37.91% 37.97% +0.06%
==========================================
Files 303 304 +1
Lines 25962 26559 +597
==========================================
+ Hits 9843 10086 +243
- Misses 15376 15717 +341
- Partials 743 756 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ropagate hostname / site as well
…usterAgent deployment
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions and a question
| | features.otlp.receiver.protocols.http.endpoint | For OTLP/HTTP. Default: '0.0.0.0:4318'. | | ||
| | features.otlp.receiver.protocols.http.hostPortConfig.enabled | Enables host port configuration | | ||
| | features.otlp.receiver.protocols.http.hostPortConfig.hostPort | Port takes a port number (0 < x < 65536) to expose on the host. (Most containers do not need this.) If HostNetwork is enabled, this value must match the ContainerPort. | | ||
| | features.privateActionRunner.enabled | Is the main switch for Private Action Runner feature. Default: false | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | features.privateActionRunner.enabled | Is the main switch for Private Action Runner feature. Default: false | | |
| | features.privateActionRunner.enabled | Enables Private Action Runner. Default: false | |
| | features.privateActionRunner.enabled | Is the main switch for Private Action Runner feature. Default: false | | ||
| | features.privateActionRunner.nodeAgent.actionsAllowlist | ActionsAllowlist specifies the list of actions that are allowed to be executed. | | ||
| | features.privateActionRunner.nodeAgent.enabled | Enables Private Action Runner on the Node Agent. Default: true (when parent Enabled is true) | | ||
| | features.privateActionRunner.nodeAgent.selfEnroll | SelfEnroll enables automatic self-enrollment for the node-level runner. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | features.privateActionRunner.nodeAgent.selfEnroll | SelfEnroll enables automatic self-enrollment for the node-level runner. | | |
| | features.privateActionRunner.nodeAgent.selfEnroll | Enables automatic self-enrollment for the node-level runner. | |
| | features.otlp.receiver.protocols.http.hostPortConfig.enabled | Enables host port configuration | | ||
| | features.otlp.receiver.protocols.http.hostPortConfig.hostPort | Port takes a port number (0 < x < 65536) to expose on the host. (Most containers do not need this.) If HostNetwork is enabled, this value must match the ContainerPort. | | ||
| | features.privateActionRunner.enabled | Is the main switch for Private Action Runner feature. Default: false | | ||
| | features.privateActionRunner.nodeAgent.actionsAllowlist | ActionsAllowlist specifies the list of actions that are allowed to be executed. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | features.privateActionRunner.nodeAgent.actionsAllowlist | ActionsAllowlist specifies the list of actions that are allowed to be executed. | | |
| | features.privateActionRunner.nodeAgent.actionsAllowlist | Specifies the list of actions that are allowed to be executed. | |
| | features.otlp.receiver.protocols.http.hostPortConfig.hostPort | Port takes a port number (0 < x < 65536) to expose on the host. (Most containers do not need this.) If HostNetwork is enabled, this value must match the ContainerPort. | | ||
| | features.privateActionRunner.enabled | Is the main switch for Private Action Runner feature. Default: false | | ||
| | features.privateActionRunner.nodeAgent.actionsAllowlist | ActionsAllowlist specifies the list of actions that are allowed to be executed. | | ||
| | features.privateActionRunner.nodeAgent.enabled | Enables Private Action Runner on the Node Agent. Default: true (when parent Enabled is true) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the parent?
| | features.privateActionRunner.nodeAgent.enabled | Enables Private Action Runner on the Node Agent. Default: true (when parent Enabled is true) | | |
| | features.privateActionRunner.nodeAgent.enabled | Enables Private Action Runner on the node Agent. Default: true (when parent Enabled is true) | |
| : OTLP ingest configuration See [link](https://docs.datadoghq.com/opentelemetry/setup/otlp_ingest_in_the_agent/?tab=kubernetesoperator) for more information. | ||
|
|
||
| `features.privateActionRunner.enabled` | ||
| : Is the main switch for Private Action Runner feature. Default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| : Is the main switch for Private Action Runner feature. Default: false | |
| : Enables Private Action Runner. Default: false |
| : ActionsAllowlist specifies the list of actions that are allowed to be executed. | ||
|
|
||
| `features.privateActionRunner.nodeAgent.enabled` | ||
| : Enables Private Action Runner on the Node Agent. Default: true (when parent Enabled is true) | ||
|
|
||
| `features.privateActionRunner.nodeAgent.selfEnroll` | ||
| : SelfEnroll enables automatic self-enrollment for the node-level runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question, what's the parent?
| : ActionsAllowlist specifies the list of actions that are allowed to be executed. | |
| `features.privateActionRunner.nodeAgent.enabled` | |
| : Enables Private Action Runner on the Node Agent. Default: true (when parent Enabled is true) | |
| `features.privateActionRunner.nodeAgent.selfEnroll` | |
| : SelfEnroll enables automatic self-enrollment for the node-level runner. | |
| : Specifies the list of actions that are allowed to be executed. | |
| `features.privateActionRunner.nodeAgent.enabled` | |
| : Enables Private Action Runner on the node Agent. Default: true (when parent Enabled is true) | |
| `features.privateActionRunner.nodeAgent.selfEnroll` | |
| : Wnables automatic self-enrollment for the node-level runner. |
What does this PR do?
Add deployment option of the Private Action Runner container on node agent
Motivation
We want to provide node agent deployment capabilities of the private action runner
Additional Notes
We're only targeting node agent in this PR but there will be a clusterAgent PR in the future (hence the wrapping of the settings)
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
The PAR in agent is available in 7.76.0 but it needs a few changes that will be available in 7.77.0 to work properly
Describe your test plan
Built the datadog operator locally, deployed it to a docker-desktop cluster with this configuration
I verified it deployed and worked correctly
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel