perf(forwarder): reuse boto3 S3 client across SQS batch records#1079
Merged
LorisFriedel merged 1 commit intomasterfrom Mar 17, 2026
Merged
perf(forwarder): reuse boto3 S3 client across SQS batch records#1079LorisFriedel merged 1 commit intomasterfrom
LorisFriedel merged 1 commit intomasterfrom
Conversation
ViBiOh
approved these changes
Mar 17, 2026
S3EventHandler._get_s3_client() created a new boto3.client("s3") per
record. For a 10-record SQS batch that means 10 client constructions
(service model parsing, session setup, connection pool init).
Extract create_s3_client() as a module-level function, accept an
optional s3_client parameter in S3EventHandler.__init__, and create the
client once in sqs_handler() before the loop.
Backward compatible: callers that omit s3_client get a client created
at construction time.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
LorisFriedel
force-pushed
the
loris.friedel/perf-reuse-s3-client
branch
from
c2b1b40 to
77e68d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3EventHandler._get_s3_client()created a newboto3.client("s3")per record (service model parsing, session setup, connection pool init)create_s3_client()as a module-level function and accept an optionals3_clientparameter inS3EventHandler.__init__sqs_handler()creates the client once before the loop and passes it to all handlerss3_clientget a client created at construction timeTest plan
test_s3_handler.pyandtest_parsing.pytests passtest_s3_tags_added_to_metadataupdated to mock_extract_datainstead of the removed_get_s3_client🤖 Generated with Claude Code