Skip to content

Conversation

@michael-richey
Copy link
Collaborator

@michael-richey michael-richey commented Sep 30, 2025

What does this PR do?

Resolves several problems with connected resources.

Description of the Change

At some point in the past connect_id was an abstract method on the base class, but it hasn't been abstract for a while, there's a default implementation now. Using pass skips over that default implementation when some classes might require it. We removed these methods that just skip the base method from several models.

The new synthetics mobile application classes and connecting resources were affected, but didn't have tests so we've added tests. These tests upload a binary file (an android apk file), since we record the tests we need to deal with recording that binary data so some changes to conftest.py

The tests revealed a hidden dependency. Some synthetics tests depend on mobile applications. Mobile application versions also depend on mobile applications. Those are both easy relationships to deal with because there's an id we use for association like every other resource (think of the id as a foreign key). However, to successfully create a link from a test to a mobile application that mobile application needs to have a version associated with it. So we add all versions of the specific app as test dependencies. These changes are in resources_handler.py

The mobile application model also had some extra fields that we cannot pass to the API and a circular dependency defined that was removed.

Finally, we generated cassettes. However, some of the mobile application tests generated cassettes that were too large for github, so the tests are skipped. Github actions won't run them but can be run locally if needed.

@michael-richey michael-richey marked this pull request as ready for review September 30, 2025 19:07
@michael-richey michael-richey requested a review from a team as a code owner September 30, 2025 19:07
@michael-richey michael-richey changed the title Remove empty connect_id methods Fix some problems with connected resources Oct 2, 2025
@michael-richey michael-richey merged commit fab514b into main Oct 21, 2025
10 checks passed
@michael-richey michael-richey deleted the michael.richey/fix-connect-id branch October 21, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants