Fix Issue 399, hand edited composite query id replacements #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyronhay
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #399 using the solution suggested in the issue.
Note: I was unable to replicate because
sync-clialways creates composite queries with spaces after the monitor ids (i.e.123 && ( 456 && 789 )never123 && (456 && 789)However, if someone had hand edited the json or made some other change to the query but kept it technically valid it does fail in the way described.Description of the Change
Used the
matchvalue, it was probably always intended to be used otherwise there's no reason for the parentheses in the regular expression.