Skip to content

Exclude assets field from monitors #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michael-richey merged 1 commit into from
Jan 15, 2026
Merged

Exclude assets field from monitors #438

michael-richey merged 1 commit into from
Jan 15, 2026

Conversation

@michael-richey
Copy link
Collaborator

@michael-richey michael-richey commented Jan 14, 2026 •
edited
Loading

What does this PR do?

Ignore the assets attribute.

The API changed so now:

  • Bulk GET has no way to return assets
  • GET returns assets based on the value of with_assets, if not provided defaults to False
  • POST & PUT always return assets

Description of the Change

Added assets to excluded_attributes for the monitor model.

@michael-richey michael-richey marked this pull request as ready for review January 14, 2026 21:24
@michael-richey michael-richey requested a review from a team as a code owner January 14, 2026 21:24
@michael-richey michael-richey merged commit d924677 into main Jan 15, 2026
21 of 24 checks passed
@michael-richey michael-richey deleted the michael.richey/monitor-api-change branch January 15, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heyronhay heyronhay heyronhay approved these changes

Assignees

No one assigned

Labels

changelog/Fixed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michael-richey @heyronhay