Skip to content

Conversation

@carlosroman
Copy link
Contributor

@carlosroman carlosroman commented Apr 24, 2025

What does this PR do?

Adds correct transport when using UDS streams.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@carlosroman carlosroman marked this pull request as ready for review April 24, 2025 14:52
@carlosroman carlosroman requested review from a team as code owners April 24, 2025 14:52
@carlosroman carlosroman force-pushed the carlosroman/add_uds_stream_support branch from f7b21e4 to 8d6df8c Compare April 24, 2025 15:26
@carlosroman carlosroman added the changelog/no-changelog Changes don't appear in changelog label Apr 24, 2025
@carlosroman carlosroman force-pushed the carlosroman/add_uds_stream_support branch from 8d6df8c to f01dd0a Compare April 24, 2025 15:28
@carlosroman carlosroman merged commit d1f3e1d into ryan.hall/add_uds_stream_support Apr 25, 2025
4 checks passed
@carlosroman carlosroman deleted the carlosroman/add_uds_stream_support branch April 25, 2025 11:11
carlosroman added a commit that referenced this pull request May 1, 2025
* AMLII-2166 - Add UDS Streams support to the DogStatsD client

Includes full support for the unix://, unixstream://, and unixgram:// socket_path prefixes
utilized by DD_DOGSTATSD_URL in preparation to support that feature.

Autodetects SOCK_DGRAM vs SOCK_STREAM for users currently providing a raw socket path.

* Fix bug with multiple threaded usage of stream sockets by guaranteeing the "size" and "message" packets are always sent one after another.

* Carlosroman/add uds stream support (#895)

* Setting correct transport type max payload size when setting the socket.

* updated broken tests (#896)

---------

Co-authored-by: Carlos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog Changes don't appear in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants