Conversation
|
@gzysk8 Have you been able to check your changes? (in particular, have you been able to confirm that these metrics actually exist in redis' I've just checked on the latest release of redis ( |
|
@olivielpeau The case I had, the client was using Azure Redis so perhaps they're specific to that? He modified the check himself and got it working - https://datadog.zendesk.com/agent/tickets/60580 Appears those metrics exist in the info from here too - http://stackoverflow.com/questions/25416562/stackexchange-redis-with-azure-redis-is-unusably-slow-or-throws-timeout-errors |
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Thanks @gzysk8! Just added a small comment, apart from that this looks good to me
| # stats | ||
| 'latest_fork_usec': 'redis.perf.latest_fork_usec', | ||
| 'bytes_received_per_sec': 'redis.bytes_received_per_sec', | ||
| 'bytes_sent_per_sec': 'redis.bytes_sent_per_sec', |
There was a problem hiding this comment.
could you add comments next to these 2 lines as a reminder that these metrics are only available on Azure Redis? :)
[redis] additional Stats metrics [Redis] add Azure Redis comment to additional stats
gzysk8
force-pushed
the
Grant/extra_Redis_metrics
branch
from
dab8315 to
25c9f40
Compare
|
The metadata should be updated in |
3 participants
What does this PR do?
Adds a couple metrics exposed in the output of the Redis info command.
Motivation
Feature request from customer.