[tests] allow tests to use additional_checksd parameter#2896
Closed
cberry777 wants to merge 2 commits intoDataDog:masterfrom
Closed
[tests] allow tests to use additional_checksd parameter#2896cberry777 wants to merge 2 commits intoDataDog:masterfrom
cberry777 wants to merge 2 commits intoDataDog:masterfrom
Conversation
|
Thanks! |
Contributor
|
Hi @cberry777, |
…d-PR1-tests_checksd
Contributor
Author
|
Closed this PR in favor of #3056. I have no idea how that binary was introduced (I believe it came from running rake?) It was easier to just create a brand new PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A one-line change that allows tests to optionally access the 'additional_checksd' parameter from the appConfig when using 'load_check()'
Motivation
This is mandatory if you want to have a set of Checks that you will not be submitting back to Datadog. And wish to use the 'additional_checksd' feature to access them. And you also want to be able to reuse Datadog's excellent AgentCheckTest and supporting code.
Testing Guidelines
N/A (it is a part of the test infrastructure)
Additional Notes
None.
It is a one-liner.
It is innocuous if you do not define 'additional_checksd' in your test's appConfig.
But without it, you must resort to dropping your code into a checkout of dd-agent's checks.d.