[service_discovery][jmx] enabling for JMX-based integrations (GRPC)#2933
Closed
[service_discovery][jmx] enabling for JMX-based integrations (GRPC)#2933
Conversation
[logging] adding some more logging.
…ity. [jmxfetch][service_discovery] increase max heap size for SD to 512.
…for it to boot too.
truthbk
changed the title
…hange (bootup changes to apply).
remh
reviewed
Oct 28, 2016
| import signal | ||
| import sys | ||
| import time | ||
| import supervisor.xmlrpc |
remh
reviewed
Oct 28, 2016
| # and modify its value. | ||
| # sd_template_dir: /datadog/check_configs | ||
| # | ||
| # JMX Service Disocvery |
There was a problem hiding this comment.
Do we need this flag ? Let's add some comments about why it's needed or not
remh
reviewed
Oct 28, 2016
| self.jmx_process.terminate() | ||
|
|
||
| def _handle_sigreload(self, signum, frame): | ||
| # Terminate jmx process on SIGTERM signal |
There was a problem hiding this comment.
Why do we need a new signal handler if we are using gRPC ?
remh
reviewed
Oct 28, 2016
| if self.previous_config_index is None: | ||
| self.previous_config_index = config_index | ||
| return False | ||
| return True |
remh
reviewed
Oct 28, 2016
|
|
||
| valid_instances = True | ||
| if config['instances'] is None or not isinstance(config['instances'], list): | ||
| valid_instances = False |
Member
|
@truthbk can we close it? |
Member
Author
|
@hkaj yes we can. Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an RPC client to enable the submission of JMX configurations (in YAML format) to JMXfetch, thus enabling service discovery for JMX-based integrations (jmxfetch). The changes introduce a dependency with grpc.io. The PR might require some polishing, but is functional at this time.
Motivation
There was a fairly obvious void in the functionalities for service discovery with regard to JMX-based integrations. This PR attempts to address that issue.
Testing Guidelines
Manual, at the moment.
Additional Notes
Note that the RPC client code is generate at build time in omnibus, so this may cause some issues in terms of linting, etc... due to unfound modules.
DataDog/omnibus-software#79
DataDog/dd-agent-omnibus#96
DataDog/jmxfetch#109
DataDog/docker-dd-agent#135