Inject defineClass glue by patching Class.forName
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/inject-via-class-forname
branch
from
56d1a24 to
e45fcda
Compare
mcculls
changed the title
defineClass glue by patching Class.forName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Patch
Class.forNameinstead ofClassLoader.loadClassto inject the define-class glue.Motivation
Patching
Class.forNameis safer because it's a static method and will work regardless if there's a custom class-loader that doesn't somehow delegate via one of theloadClassmethods. While this is extremely unlikely, switching toClass.forNamecloses this gap.Patching
Class.forNameis very slightly slower (0.5ms) but this only happens once.