Merge pull request #2670 from DataDog/nogorodnikov/better-projects-dependency-resolution-for-detekt

RUM-10120: Better project-type dependency resolution for Detekt custom rules execution

Author: 0xnm

buildSrc/src/main/kotlin/com/datadog/gradle/config/DetektCustomConfig.kt

@@ -8,6 +8,7 @@ package com.datadog.gradle.config
 
 import com.android.build.gradle.LibraryExtension
 import org.gradle.api.Project
+import org.gradle.api.artifacts.ProjectDependency
 import org.gradle.api.file.FileCollection
 import org.gradle.api.file.FileTree
 import org.gradle.api.internal.file.UnionFileTree
@@ -17,9 +18,7 @@ import org.gradle.api.tasks.JavaExec
 import java.io.File
 import java.util.Properties
 
-fun Project.detektCustomConfig(
-    vararg moduleDependencies: String
-) {
+fun Project.detektCustomConfig() {
     val ext = extensions.findByType(LibraryExtension::class.java)
 
     tasks.register("printDetektClasspath") {
@@ -99,6 +98,23 @@ fun Project.detektCustomConfig(
         args("-ex", "**/*.kts")
         args("--jvm-target", "11")
 
+        val moduleDependencies = configurations
+            .filter { it.name == "implementation" || it.name == "api" }
+            .flatMap { it.dependencies.filterIsInstance<ProjectDependency>() }
+            .map { it.path }
+            .toSet()
+            .let {
+                // api configurations have canBeResolved=false, so we cannot go inside them to see transitive
+                // module dependencies, so including common modules
+                if (project.path == ":dd-sdk-android-internal") {
+                    it
+                } else if (project.path == ":dd-sdk-android-core") {
+                    it + ":dd-sdk-android-internal"
+                } else {
+                    it + setOf(":dd-sdk-android-core", ":dd-sdk-android-internal")
+                }
+            }
+
         val externalDependencies = File("${projectDir.absolutePath}/detekt_classpath").readText()
         val moduleDependenciesClasses = moduleDependencies.map {
             "${rootDir.absolutePath}${it.replace(':', '/')}/build/extracted/classes.jar"

features/dd-sdk-android-logs/build.gradle.kts

@@ -88,4 +88,4 @@ publishingConfig(
     "The Logs feature to use with the Datadog monitoring " +
         "library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal")
+detektCustomConfig()

features/dd-sdk-android-ndk/build.gradle.kts

@@ -109,4 +109,4 @@ dependencyUpdateConfig()
 publishingConfig(
     "An NDK integration to use with the Datadog monitoring library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-core")
+detektCustomConfig()

features/dd-sdk-android-rum/build.gradle.kts

@@ -118,4 +118,4 @@ publishingConfig(
     "The RUM feature to use with the Datadog monitoring " +
         "library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal")
+detektCustomConfig()

features/dd-sdk-android-session-replay-compose/build.gradle.kts

@@ -87,8 +87,4 @@ dependencyUpdateConfig()
 publishingConfig(
     "Session Replay Extension Support for Jetpack Compose."
 )
-detektCustomConfig(
-    ":dd-sdk-android-core",
-    ":dd-sdk-android-internal",
-    ":features:dd-sdk-android-session-replay"
-)
+detektCustomConfig()

features/dd-sdk-android-session-replay-material/build.gradle.kts

@@ -70,4 +70,4 @@ dependencyUpdateConfig()
 publishingConfig(
     "Session Replay Extension Support for Material UI components."
 )
-detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal", ":features:dd-sdk-android-session-replay")
+detektCustomConfig()

features/dd-sdk-android-session-replay/build.gradle.kts

@@ -90,4 +90,4 @@ publishingConfig(
     "The Session Replay feature to use with the Datadog monitoring " +
         "library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal")
+detektCustomConfig()

features/dd-sdk-android-trace-otel/build.gradle.kts

@@ -88,4 +88,4 @@ dependencyUpdateConfig()
 publishingConfig(
     "The tracing library for Android, providing OpenTelemetry compatibility."
 )
-detektCustomConfig(":dd-sdk-android-core", ":features:dd-sdk-android-trace")
+detektCustomConfig()

features/dd-sdk-android-trace/build.gradle.kts

@@ -93,4 +93,4 @@ publishingConfig(
     "The Tracing feature to use with the Datadog monitoring " +
         "library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-core", ":dd-sdk-android-internal")
+detektCustomConfig()

features/dd-sdk-android-webview/build.gradle.kts

@@ -81,4 +81,4 @@ publishingConfig(
     "The WebView integration feature to use with the Datadog monitoring " +
         "library for Android applications."
 )
-detektCustomConfig(":dd-sdk-android-internal")
+detektCustomConfig()