network request exception

Author: typotter

features/dd-sdk-android-flags/api/apiSurface

@@ -28,6 +28,8 @@ data class com.datadog.android.flags.FlagsConfiguration
   companion object 
 interface com.datadog.android.flags.FlagsStateListener
   fun onStateChanged(com.datadog.android.flags.model.FlagsClientState)
+class com.datadog.android.flags.NetworkRequestFailedException : RuntimeException
+  constructor(String)
 interface com.datadog.android.flags.StateObservable
   fun getCurrentState(): com.datadog.android.flags.model.FlagsClientState
   fun addListener(FlagsStateListener)

features/dd-sdk-android-flags/api/dd-sdk-android-flags.api

@@ -69,6 +69,10 @@ public abstract interface class com/datadog/android/flags/FlagsStateListener {
 	public abstract fun onStateChanged (Lcom/datadog/android/flags/model/FlagsClientState;)V
 }
 
+public final class com/datadog/android/flags/NetworkRequestFailedException : java/lang/RuntimeException {
+	public fun <init> (Ljava/lang/String;)V
+}
+
 public abstract interface class com/datadog/android/flags/StateObservable {
 	public abstract fun addListener (Lcom/datadog/android/flags/FlagsStateListener;)V
 	public abstract fun getCurrentState ()Lcom/datadog/android/flags/model/FlagsClientState;

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/NetworkRequestFailedException.kt

@@ -0,0 +1,18 @@
+/*
+ * Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0.
+ * This product includes software developed at Datadog (https://www.datadoghq.com/).
+ * Copyright 2016-Present Datadog, Inc.
+ */
+
+package com.datadog.android.flags
+
+/**
+ * Exception thrown when a network request for flag evaluations fails.
+ *
+ * This exception is used to communicate network failures when updating evaluation contexts.
+ * It provides a clear signal that the failure was due to network connectivity issues rather
+ * than application logic errors.
+ *
+ * @param message A descriptive message about the network failure
+ */
+class NetworkRequestFailedException(message: String) : RuntimeException(message)

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/evaluation/EvaluationsManager.kt

@@ -9,6 +9,7 @@ package com.datadog.android.flags.internal.evaluation
 import com.datadog.android.api.InternalLogger
 import com.datadog.android.core.internal.utils.executeSafe
 import com.datadog.android.flags.EvaluationContextCallback
+import com.datadog.android.flags.NetworkRequestFailedException
 import com.datadog.android.flags.internal.FlagsStateManager
 import com.datadog.android.flags.internal.net.PrecomputedAssignmentsReader
 import com.datadog.android.flags.internal.repository.FlagsRepository
@@ -86,7 +87,7 @@ internal class EvaluationsManager(
                     { NETWORK_REQUEST_FAILED_MESSAGE }
                 )
 
-                val throwable = Throwable(NETWORK_REQUEST_FAILED_MESSAGE)
+                val throwable = NetworkRequestFailedException(NETWORK_REQUEST_FAILED_MESSAGE)
                 if (hadFlags) {
                     flagStateManager.updateState(FlagsClientState.Stale)
                 } else {

features/dd-sdk-android-flags/src/test/kotlin/com/datadog/android/flags/internal/evaluation/EvaluationsManagerTest.kt

@@ -21,6 +21,7 @@ import okhttp3.mockwebserver.MockWebServer
 import org.assertj.core.api.Assertions.assertThat
 import org.json.JSONObject
 import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.Assertions.assertDoesNotThrow
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.ExtendWith
@@ -32,6 +33,7 @@ import org.mockito.kotlin.anyOrNull
 import org.mockito.kotlin.argumentCaptor
 import org.mockito.kotlin.eq
 import org.mockito.kotlin.inOrder
+import org.mockito.kotlin.mock
 import org.mockito.kotlin.times
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
@@ -289,7 +291,7 @@ internal class EvaluationsManagerTest {
     fun `M invoke onSuccess W updateEvaluationsForContext() { success }`() {
         // Given
         val publicContext = EvaluationContext(fakeTargetingKey, emptyMap())
-        val mockCallback = org.mockito.kotlin.mock<EvaluationContextCallback>()
+        val mockCallback = mock<EvaluationContextCallback>()
         val jsonResponse = "{\"data\": {\"attributes\": {\"flags\": {}}}}"
         val flagsMap = emptyMap<String, PrecomputedFlag>()