Skip to content

Conversation

satween
Copy link
Contributor

@satween satween commented Aug 12, 2025

What does this PR do?

Adds telemetry logs for feature operations methods

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween satween requested review from a team as code owners August 12, 2025 17:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.06%. Comparing base (408586a) to head (3220078).

Files with missing lines Patch % Lines
...ndroid/telemetry/internal/TelemetryEventHandler.kt 78.95% 6 Missing and 2 partials ⚠️
...droid/internal/telemetry/InternalTelemetryEvent.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/featureoperations    #2818      +/-   ##
=============================================================
+ Coverage                      70.00%   70.06%   +0.06%     
=============================================================
  Files                            835      835              
  Lines                          31444    31462      +18     
  Branches                        5277     5279       +2     
=============================================================
+ Hits                           22012    22042      +30     
+ Misses                          7938     7932       -6     
+ Partials                        1494     1488       -6     
Files with missing lines Coverage Δ
...g/android/rum/internal/domain/scope/RumEventExt.kt 92.43% <ø> (+1.58%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 86.70% <100.00%> (-0.09%) ⬇️
...droid/internal/telemetry/InternalTelemetryEvent.kt 25.00% <0.00%> (-5.00%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 85.81% <78.95%> (-1.98%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween satween force-pushed the tvaleev/feature/RUM-11253 branch from 6a75d81 to 1fc34ea Compare August 13, 2025 13:51
@satween satween changed the title [RUM-11253] FO: Adding telemetry for basic methods [RUM-11253][FO]: Adding telemetry for basic methods Aug 25, 2025
@satween satween force-pushed the tvaleev/feature/RUM-11253 branch from 1fc34ea to 3220078 Compare August 25, 2025 12:52
@satween satween requested a review from ambushwork August 25, 2025 12:52
forge: Forge
) {
// Given
val mockInternalLogger = mock<InternalLogger>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor, this can be mock as a local variable and reused in every test case

InternalTelemetryEvent.ApiUsage.AddOperationStepVital.ActionType.SUCCEED
),
samplingRate = 15f
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: nice to verify no more interactions of logApiUsage

@satween
Copy link
Contributor Author

satween commented Aug 25, 2025

Going to address tests notes in this PR

@satween satween merged commit a46b8f7 into feature/featureoperations Aug 25, 2025
25 checks passed
@satween satween deleted the tvaleev/feature/RUM-11253 branch August 25, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants