-
Notifications
You must be signed in to change notification settings - Fork 71
[RUM-11253][FO]: Adding telemetry for basic methods #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/featureoperations #2818 +/- ##
=============================================================
+ Coverage 70.00% 70.06% +0.06%
=============================================================
Files 835 835
Lines 31444 31462 +18
Branches 5277 5279 +2
=============================================================
+ Hits 22012 22042 +30
+ Misses 7938 7932 -6
+ Partials 1494 1488 -6
🚀 New features to boost your workflow:
|
...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
Outdated
Show resolved
Hide resolved
6a75d81
to
1fc34ea
Compare
1fc34ea
to
3220078
Compare
...ndroid-rum/src/test/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitorTest.kt
Show resolved
Hide resolved
forge: Forge | ||
) { | ||
// Given | ||
val mockInternalLogger = mock<InternalLogger>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor, this can be mock as a local variable and reused in every test case
InternalTelemetryEvent.ApiUsage.AddOperationStepVital.ActionType.SUCCEED | ||
), | ||
samplingRate = 15f | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: nice to verify no more interactions of logApiUsage
Going to address tests notes in this PR |
What does this PR do?
Adds telemetry logs for feature operations methods
Review checklist (to be filled by reviewers)