Skip to content

Conversation

sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Oct 6, 2025

What does this PR do?

This PR updates and properly exposes the full attribute API. It does the following:

  • Removes the existing setAttributes functions.
  • Implements addAttribute and addAttributes
  • Implements removeAttribute and removeAttributes
  • Adds tests for them all, both at JS and native levels.

Motivation

We need to align and properly expose existing APIs from the native SDKs.

Additional notes

ios_old_arch android_old_arch

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio force-pushed the sbarrio/RUM-8891/polish-attribute-api branch from 1f28ee8 to c2c70e8 Compare October 7, 2025 07:35
@sbarrio sbarrio self-assigned this Oct 7, 2025
@sbarrio sbarrio changed the title [RUM 8891] Polish add/removeAttribute API [RUM 8891] [v3] Polish add/removeAttribute API Oct 7, 2025
@sbarrio sbarrio force-pushed the sbarrio/RUM-8891/polish-attribute-api branch from c2c70e8 to 1290eff Compare October 8, 2025 13:36
*/

import { DefaultTimeProvider, RumActionType } from "@datadog/mobile-react-native";
import { ErrorSource } from "@datadog/mobile-react-native/lib/typescript/rum/types";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import was wrong and somehow slipped by us so I decided to fix it here.

@sbarrio sbarrio force-pushed the sbarrio/RUM-8891/polish-attribute-api branch from 1290eff to 21abb57 Compare October 8, 2025 13:40
Copy link

datadog-official bot commented Oct 8, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: de38d91 | Docs | Was this helpful? Give us feedback!

@sbarrio sbarrio force-pushed the sbarrio/RUM-8891/polish-attribute-api branch from 21abb57 to d9c8f2a Compare October 8, 2025 14:51
@sbarrio sbarrio force-pushed the sbarrio/RUM-8891/polish-attribute-api branch from d9c8f2a to de38d91 Compare October 8, 2025 15:35
@sbarrio sbarrio marked this pull request as ready for review October 9, 2025 07:41
@sbarrio sbarrio requested a review from a team as a code owner October 9, 2025 07:41
@sbarrio sbarrio changed the title [RUM 8891] [v3] Polish add/removeAttribute API [RUM 8891] [V3] Polish add/removeAttribute API Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants