Skip to content

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Fixes an issue for which serviceName is not picked up properly on Expo, by falling back to project.datadog.serviceName when project.ext.datadog.serviceName is not defined.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner August 8, 2025 15:20
Copy link
Contributor

@sbarrio sbarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@marco-saia-datadog marco-saia-datadog merged commit 38e55df into develop Aug 28, 2025
10 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/fix/expo-service-name branch August 28, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants