[RUM-11283] Improve Babel Plugin support for TextInput component #957
+126
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While the Babel plugin already supports
TextInput
automatic wrapping, it only does so when users define theonFocus
attribute, which is the same behavior we have for other elements, like buttons.The main different here, is that for buttons having an
onPress
attribute is essential for the basic functionality, while onTextInputs
, the main functionality comes from theonChangeText
attribute.So when
onFocus
is not present, we should make the babel plugin add it so our wrapping logic works even if the user’s code does not include it.Review checklist (to be filled by reviewers)