[RUM-11283] Improve Babel Plugin support for TextInput component #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbarrio
approved these changes
Aug 12, 2025
Ensure `onFocus` attribute is added if not present already, so our wrapping logic can happen.
cdn34dd
force-pushed
the
carlosnogueira/RUM-11283/improve-babel-support-text-inputs
branch
from
2ad5d19 to
0e2ab3f
Compare
cdn34dd
deleted the
carlosnogueira/RUM-11283/improve-babel-support-text-inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While the Babel plugin already supports
TextInputautomatic wrapping, it only does so when users define theonFocusattribute, which is the same behavior we have for other elements, like buttons.The main different here, is that for buttons having an
onPressattribute is essential for the basic functionality, while onTextInputs, the main functionality comes from theonChangeTextattribute.So when
onFocusis not present, we should make the babel plugin add it so our wrapping logic works even if the user’s code does not include it.Review checklist (to be filled by reviewers)