Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 93.60% 93.16% -0.45%
==========================================
Files 73 73
Lines 4256 4286 +30
==========================================
+ Hits 3984 3993 +9
- Misses 272 293 +21 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Feb 14, 2025
dubloom
reviewed
Feb 14, 2025
Contributor
dubloom
left a comment
There was a problem hiding this comment.
LGTM overall. Don't we want to add a test for logs payload as well ? Maybe you want to do it after the refactoring. I could get that.
| class Telemetry { | ||
| /// The telemetry class is responsible for handling internal telemetry data to | ||
| /// track Datadog product usage. It _can_ collect and report logs and metrics. | ||
| /// |
Contributor
There was a problem hiding this comment.
Don't we have private headers ? If yes, is there a reason to put the file in the public headers and say do not use ?
Collaborator
Author
There was a problem hiding this comment.
Imagine I am implementing appsec, how Datadog user/integrator outside of the tracer could use it if it's private?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support telemetry logs
Note to reviewers
This PR only adds the API for collecting and reporting logs. As of now, the library is not yet reporting logs because I am planning to refactor the whole telemetry module and error handling.