Skip to content

[NOT FOR MERGING] upgrade packages #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 109 commits into
base: dotnet10/UpdateToPreview
Choose a base branch
from

Conversation

NachoEchevarria
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Aug 1, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7319) - mean (69ms)  : 63, 75
     .   : milestone, 69,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (1,031ms)  : 1008, 1054
     .   : milestone, 1031,
    master - mean (1,028ms)  : 1006, 1050
     .   : milestone, 1028,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (107ms)  : 105, 108
     .   : milestone, 107,
    master - mean (108ms)  : 106, 109
     .   : milestone, 108,

    section Baseline
    This PR (7319) - mean (106ms)  : 104, 109
     .   : milestone, 106,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (721ms)  : 709, 734
     .   : milestone, 721,
    master - mean (724ms)  : 713, 736
     .   : milestone, 724,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (95ms)  : 94, 96
     .   : milestone, 95,
    master - mean (95ms)  : 94, 96
     .   : milestone, 95,

    section Baseline
    This PR (7319) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (94ms)  : 93, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (677ms)  : 665, 688
     .   : milestone, 677,
    master - mean (681ms)  : 671, 691
     .   : milestone, 681,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (94ms)  : 92, 95
     .   : milestone, 94,

    section Baseline
    This PR (7319) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (614ms)  : 605, 624
     .   : milestone, 614,
    master - mean (622ms)  : 610, 634
     .   : milestone, 622,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (211ms)  : 201, 220
     .   : milestone, 211,
    master - mean (219ms)  : 205, 232
     .   : milestone, 219,

    section Baseline
    This PR (7319) - mean (207ms)  : 193, 221
     .   : milestone, 207,
    master - mean (206ms)  : 194, 217
     .   : milestone, 206,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (1,204ms)  : 1154, 1255
     .   : milestone, 1204,
    master - mean (1,228ms)  : 1176, 1281
     .   : milestone, 1228,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (290ms)  : 280, 299
     .   : milestone, 290,
    master - mean (308ms)  : 293, 324
     .   : milestone, 308,

    section Baseline
    This PR (7319) - mean (285ms)  : 277, 293
     .   : milestone, 285,
    master - mean (305ms)  : 288, 322
     .   : milestone, 305,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (967ms)  : 941, 993
     .   : milestone, 967,
    master - mean (999ms)  : 948, 1050
     .   : milestone, 999,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (284ms)  : 276, 291
     .   : milestone, 284,
    master - mean (295ms)  : 280, 311
     .   : milestone, 295,

    section Baseline
    This PR (7319) - mean (283ms)  : 276, 290
     .   : milestone, 283,
    master - mean (297ms)  : 279, 316
     .   : milestone, 297,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (946ms)  : 901, 991
     .   : milestone, 946,
    master - mean (947ms)  : 911, 984
     .   : milestone, 947,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (300ms)  : crit, 284, 316
     .   : crit, milestone, 300,
    master - mean (280ms)  : 271, 289
     .   : milestone, 280,

    section Baseline
    This PR (7319) - mean (291ms)  : 271, 312
     .   : milestone, 291,
    master - mean (279ms)  : 269, 290
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (903ms)  : crit, 810, 996
     .   : crit, milestone, 903,
    master - mean (848ms)  : 821, 875
     .   : milestone, 848,

Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 1, 2025

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 63b5fd6 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 8, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7319 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.546
  • 3 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.4μs 58.2ns 363ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.4μs 67.4ns 309ns 0 0 0 5.69 KB
master StartStopWithChild net472 21.4μs 104ns 519ns 0.87 0.217 0 6.08 KB
#7319 StartStopWithChild net6.0 10.6μs 59ns 349ns 0 0 0 5.5 KB
#7319 StartStopWithChild netcoreapp3.1 13.7μs 68.5ns 291ns 0 0 0 5.71 KB
#7319 StartStopWithChild net472 21.8μs 97.3ns 351ns 0.898 0.224 0 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 944μs 114ns 440ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 79.7ns 276ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 66.1ns 247ns 0 0 0 3.31 KB
#7319 WriteAndFlushEnrichedTraces net6.0 927μs 207ns 776ns 0 0 0 2.7 KB
#7319 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 30.9ns 116ns 0 0 0 2.7 KB
#7319 WriteAndFlushEnrichedTraces net472 1.19ms 93ns 360ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 335μs 129ns 483ns 0 0 0 198.49 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 2.27μs 8.77μs 0 0 0 206.2 KB
master AllCycleSimpleBody net472 451μs 71.5ns 277ns 37.9 2.23 0 246.48 KB
master AllCycleMoreComplexBody net6.0 341μs 1.55μs 6.01μs 0 0 0 202 KB
master AllCycleMoreComplexBody netcoreapp3.1 502μs 196ns 734ns 0 0 0 209.62 KB
master AllCycleMoreComplexBody net472 457μs 112ns 419ns 37.9 2.23 0 249.99 KB
master ObjectExtractorSimpleBody net6.0 317ns 0.104ns 0.402ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 404ns 2.3ns 15.9ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 301ns 0.423ns 1.64ns 0.044 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.26μs 27.8ns 108ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 28.1ns 105ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.75μs 8.31ns 32.2ns 0.577 0 0 3.8 KB
#7319 AllCycleSimpleBody net6.0 336μs 1.2μs 4.33μs 0 0 0 198.49 KB
#7319 AllCycleSimpleBody netcoreapp3.1 486μs 1μs 3.61μs 0 0 0 206.2 KB
#7319 AllCycleSimpleBody net472 452μs 86.8ns 336ns 37.9 2.23 0 246.48 KB
#7319 AllCycleMoreComplexBody net6.0 344μs 202ns 757ns 0 0 0 202 KB
#7319 AllCycleMoreComplexBody netcoreapp3.1 518μs 2.51μs 10μs 0 0 0 209.62 KB
#7319 AllCycleMoreComplexBody net472 458μs 83.4ns 312ns 37.9 2.23 0 249.99 KB
#7319 ObjectExtractorSimpleBody net6.0 316ns 1.72ns 9.09ns 0 0 0 280 B
#7319 ObjectExtractorSimpleBody netcoreapp3.1 404ns 2.19ns 12ns 0 0 0 272 B
#7319 ObjectExtractorSimpleBody net472 306ns 0.0275ns 0.0992ns 0.0445 0 0 281 B
#7319 ObjectExtractorMoreComplexBody net6.0 6.31μs 22.9ns 88.8ns 0 0 0 3.78 KB
#7319 ObjectExtractorMoreComplexBody netcoreapp3.1 7.84μs 39.6ns 181ns 0 0 0 3.69 KB
#7319 ObjectExtractorMoreComplexBody net472 6.72μs 6.94ns 25ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 79μs 211ns 819ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 98μs 206ns 798ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 15ns 58.2ns 4.92 0 0 32.5 KB
master EncodeLegacyArgs net6.0 143μs 26.3ns 102ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 63.9ns 247ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 262μs 17.8ns 66.6ns 0 0 0 2.16 KB
#7319 EncodeArgs net6.0 87μs 232ns 869ns 0 0 0 32.4 KB
#7319 EncodeArgs netcoreapp3.1 98μs 34.3ns 133ns 0 0 0 32.4 KB
#7319 EncodeArgs net472 112μs 139ns 539ns 5.04 0 0 32.51 KB
#7319 EncodeLegacyArgs net6.0 146μs 46.2ns 167ns 0 0 0 2.15 KB
#7319 EncodeLegacyArgs netcoreapp3.1 200μs 55.2ns 214ns 0 0 0 2.14 KB
#7319 EncodeLegacyArgs net472 263μs 95.1ns 329ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.072 414,277.92 858,510.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 397μs 68.3ns 265ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 414μs 91.6ns 330ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 432μs 99.1ns 384ns 0 0 0 4.68 KB
master RunWafRealisticBenchmarkWithAttack net6.0 289μs 245ns 948ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 675μs 14.2μs 141μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 316μs 23ns 86ns 0 0 0 2.29 KB
#7319 RunWafRealisticBenchmark net6.0 399μs 129ns 463ns 0 0 0 4.55 KB
#7319 RunWafRealisticBenchmark netcoreapp3.1 855μs 2.79μs 10.4μs 0 0 0 4.5 KB
#7319 RunWafRealisticBenchmark net472 430μs 130ns 502ns 0 0 0 4.66 KB
#7319 RunWafRealisticBenchmarkWithAttack net6.0 289μs 177ns 686ns 0 0 0 2.24 KB
#7319 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 722μs 3.36μs 13μs 0 0 0 2.22 KB
#7319 RunWafRealisticBenchmarkWithAttack net472 314μs 14.7ns 55ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 14.6 KB 14.52 KB -80 B -0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 59.8μs 102ns 366ns 0 0 0 14.6 KB
master SendRequest netcoreapp3.1 72.3μs 363ns 1.58μs 0 0 0 17.42 KB
master SendRequest net472 0.0204ns 0.00169ns 0.00656ns 0 0 0 0 b
#7319 SendRequest net6.0 60.2μs 48.2ns 180ns 0 0 0 14.52 KB
#7319 SendRequest netcoreapp3.1 71.2μs 66.8ns 250ns 0 0 0 17.42 KB
#7319 SendRequest net472 0.00982ns 0.00197ns 0.00764ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 1.153 835,997.27 964,269.53

Fewer allocations 🎉 in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 7 B 4 B -3 B -42.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.88ms 258ns 999ns 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.15ms 5.71μs 21.4μs 0 0 0 640 KB
master OriginalCharSlice net472 2.65ms 84.5ns 305ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.36ms 444ns 1.72μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.8ms 340ns 1.32μs 0 0 0 1 B
master OptimizedCharSlice net472 1.93ms 170ns 658ns 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 836μs 20ns 77.6ns 0 0 0 1 B
master OptimizedCharSliceWithPool netcoreapp3.1 859μs 66.5ns 249ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 239ns 924ns 0 0 0 0 b
#7319 OriginalCharSlice net6.0 1.9ms 647ns 2.42μs 0 0 0 640 KB
#7319 OriginalCharSlice netcoreapp3.1 2.13ms 9.88μs 40.7μs 0 0 0 640 KB
#7319 OriginalCharSlice net472 2.7ms 429ns 1.6μs 100 0 0 641.95 KB
#7319 OptimizedCharSlice net6.0 1.43ms 115ns 429ns 0 0 0 4 B
#7319 OptimizedCharSlice netcoreapp3.1 1.8ms 193ns 721ns 0 0 0 1 B
#7319 OptimizedCharSlice net472 1.98ms 221ns 856ns 0 0 0 0 b
#7319 OptimizedCharSliceWithPool net6.0 964μs 153ns 594ns 0 0 0 1 B
#7319 OptimizedCharSliceWithPool netcoreapp3.1 838μs 140ns 544ns 0 0 0 1 B
#7319 OptimizedCharSliceWithPool net472 1.13ms 200ns 775ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.86 KB 42.48 KB 619 B 1.48%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 748μs 4.15μs 27.8μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 1.11μs 4.28μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 882μs 2.9μs 11.2μs 8.33 0 0 56.15 KB
#7319 WriteAndFlushEnrichedTraces net6.0 679μs 637ns 2.47μs 0 0 0 41.66 KB
#7319 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.25μs 4.69μs 0 0 0 42.48 KB
#7319 WriteAndFlushEnrichedTraces net472 874μs 2.7μs 10.1μs 4.46 0 0 55.92 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.92μs 1.8ns 6.97ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.51μs 9.54ns 36.9ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.73μs 6.52ns 25.2ns 0.147 0.0134 0 987 B
#7319 ExecuteNonQuery net6.0 1.9μs 5.68ns 19.7ns 0 0 0 1.02 KB
#7319 ExecuteNonQuery netcoreapp3.1 2.5μs 10.8ns 42ns 0 0 0 1.02 KB
#7319 ExecuteNonQuery net472 2.66μs 3.2ns 12ns 0.144 0.0131 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.68μs 8.1ns 33.4ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.28μs 9.11ns 35.3ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.6μs 4.54ns 17.6ns 0.161 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.83μs 2.57ns 9.94ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.41μs 11.7ns 48.2ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.7μs 2.5ns 9.37ns 0.167 0 0 1.1 KB
#7319 CallElasticsearch net6.0 1.68μs 3.74ns 14.5ns 0 0 0 1.03 KB
#7319 CallElasticsearch netcoreapp3.1 2.37μs 7.71ns 29.9ns 0 0 0 1.03 KB
#7319 CallElasticsearch net472 3.56μs 4.76ns 18.4ns 0.159 0 0 1.04 KB
#7319 CallElasticsearchAsync net6.0 1.77μs 8.77ns 38.2ns 0 0 0 1.01 KB
#7319 CallElasticsearchAsync netcoreapp3.1 2.49μs 9.1ns 35.3ns 0 0 0 1.08 KB
#7319 CallElasticsearchAsync net472 3.73μs 2.67ns 10.3ns 0.167 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.81μs 0.72ns 2.69ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.31μs 0.846ns 3.16ns 0 0 0 952 B
master ExecuteAsync net472 2.54μs 2.53ns 9.48ns 0.139 0 0 915 B
#7319 ExecuteAsync net6.0 1.78μs 3.72ns 14.4ns 0 0 0 952 B
#7319 ExecuteAsync netcoreapp3.1 2.25μs 10.5ns 42.1ns 0 0 0 952 B
#7319 ExecuteAsync net472 2.52μs 4.6ns 17.8ns 0.138 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.84μs 12ns 44.8ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.39μs 25.1ns 97.3ns 0 0 0 2.9 KB
master SendAsync net472 11.9μs 16.4ns 63.5ns 0.474 0 0 3.18 KB
#7319 SendAsync net6.0 6.71μs 8.97ns 34.7ns 0 0 0 2.36 KB
#7319 SendAsync netcoreapp3.1 8.36μs 8.83ns 31.8ns 0 0 0 2.9 KB
#7319 SendAsync net472 12.1μs 7.92ns 30.7ns 0.482 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.91 KB 43.22 KB 304 B 0.71%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 273.99 KB 275.5 KB 1.5 KB 0.55%

Fewer allocations 🎉 in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 276.9 KB 258.6 KB -18.3 KB -6.61%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 48.4μs 276ns 2.1μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 55.6μs 798ns 7.94μs 0 0 0 42.91 KB
master StringConcatBenchmark net472 57.2μs 267ns 1.28μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 487μs 2.39μs 9.84μs 0 0 0 276.9 KB
master StringConcatAspectBenchmark netcoreapp3.1 511μs 2.65μs 12.4μs 0 0 0 273.99 KB
master StringConcatAspectBenchmark net472 406μs 2.29μs 15.9μs 0 0 0 278.53 KB
#7319 StringConcatBenchmark net6.0 51.2μs 497ns 4.79μs 0 0 0 43.85 KB
#7319 StringConcatBenchmark netcoreapp3.1 51.6μs 516ns 4.95μs 0 0 0 43.22 KB
#7319 StringConcatBenchmark net472 58.9μs 282ns 1.09μs 0 0 0 57.34 KB
#7319 StringConcatAspectBenchmark net6.0 461μs 2.12μs 7.66μs 0 0 0 258.6 KB
#7319 StringConcatAspectBenchmark netcoreapp3.1 519μs 2.49μs 10.6μs 0 0 0 275.5 KB
#7319 StringConcatAspectBenchmark net472 407μs 2.27μs 15.6μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.57μs 2.44ns 9.44ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.44μs 14.7ns 57ns 0 0 0 1.7 KB
master EnrichedLog net472 3.83μs 2.76ns 10.7ns 0.249 0 0 1.64 KB
#7319 EnrichedLog net6.0 2.57μs 1.17ns 4.52ns 0 0 0 1.7 KB
#7319 EnrichedLog netcoreapp3.1 3.42μs 17.9ns 84ns 0 0 0 1.7 KB
#7319 EnrichedLog net472 3.82μs 1.99ns 7.71ns 0.248 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 272ns 1.02μs 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 106ns 397ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 167ns 647ns 0 0 0 4.52 KB
#7319 EnrichedLog net6.0 123μs 321ns 1.2μs 0 0 0 4.31 KB
#7319 EnrichedLog netcoreapp3.1 128μs 96.7ns 362ns 0 0 0 4.31 KB
#7319 EnrichedLog net472 167μs 175ns 677ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.9μs 5.58ns 21.6ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.63μs 24.3ns 94.1ns 0 0 0 2.26 KB
master EnrichedLog net472 7.52μs 6.21ns 24.1ns 0.301 0 0 2.08 KB
#7319 EnrichedLog net6.0 4.79μs 19.8ns 76.8ns 0 0 0 2.26 KB
#7319 EnrichedLog netcoreapp3.1 6.77μs 12.1ns 46.8ns 0 0 0 2.26 KB
#7319 EnrichedLog net472 7.52μs 8.98ns 34.8ns 0.3 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.96μs 6.09ns 22.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.56μs 12.7ns 53.8ns 0 0 0 1.2 KB
master SendReceive net472 3.13μs 2.74ns 10.6ns 0.189 0 0 1.2 KB
#7319 SendReceive net6.0 2.08μs 0.74ns 2.77ns 0 0 0 1.2 KB
#7319 SendReceive netcoreapp3.1 2.64μs 2.98ns 11.5ns 0 0 0 1.2 KB
#7319 SendReceive net472 3.28μs 3.11ns 12ns 0.179 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.26μs 7.25ns 27.1ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.35μs 22.9ns 88.8ns 0 0 0 1.63 KB
master EnrichedLog net472 6.6μs 10.6ns 41.2ns 0.293 0 0 2.03 KB
#7319 EnrichedLog net6.0 4.22μs 4.63ns 17.9ns 0 0 0 1.58 KB
#7319 EnrichedLog netcoreapp3.1 5.52μs 12.3ns 47.6ns 0 0 0 1.63 KB
#7319 EnrichedLog net472 6.58μs 6.58ns 23.7ns 0.295 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 745ns 3.77ns 16ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 927ns 4.74ns 21.7ns 0 0 0 576 B
master StartFinishSpan net472 893ns 0.962ns 3.72ns 0.089 0 0 578 B
master StartFinishScope net6.0 888ns 1.6ns 6.2ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.14μs 6.18ns 34.4ns 0 0 0 696 B
master StartFinishScope net472 1.12μs 0.177ns 0.662ns 0.101 0 0 658 B
#7319 StartFinishSpan net6.0 746ns 0.602ns 2.17ns 0 0 0 576 B
#7319 StartFinishSpan netcoreapp3.1 943ns 5.11ns 29.4ns 0 0 0 576 B
#7319 StartFinishSpan net472 915ns 0.211ns 0.79ns 0.0917 0 0 578 B
#7319 StartFinishScope net6.0 881ns 4.81ns 27.6ns 0 0 0 696 B
#7319 StartFinishScope netcoreapp3.1 1.12μs 5.45ns 24.4ns 0 0 0 696 B
#7319 StartFinishScope net472 1.12μs 0.251ns 0.938ns 0.101 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.05μs 3.23ns 12.5ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.39μs 7.23ns 33.1ns 0 0 0 696 B
master RunOnMethodBegin net472 1.44μs 1.86ns 7.21ns 0.101 0 0 658 B
#7319 RunOnMethodBegin net6.0 1.03μs 5.02ns 21.3ns 0 0 0 696 B
#7319 RunOnMethodBegin netcoreapp3.1 1.37μs 5.1ns 19.8ns 0 0 0 696 B
#7319 RunOnMethodBegin net472 1.41μs 0.728ns 2.72ns 0.0989 0 0 658 B

@NachoEchevarria NachoEchevarria changed the title upgrade packages [NOT FOR MERGING] upgrade packages Aug 8, 2025
NachoEchevarria and others added 26 commits August 8, 2025 17:31
…Core5/Samples.Security.AspNetCore5.csproj

Co-authored-by: Andrew Lock <[email protected]>
…dTests/Samples.InstrumentedTests.csproj

Co-authored-by: Andrew Lock <[email protected]>
…dTests/Samples.InstrumentedTests.csproj

Co-authored-by: Andrew Lock <[email protected]>
…dTests/Samples.InstrumentedTests.csproj

Co-authored-by: Andrew Lock <[email protected]>
…dTests/Samples.InstrumentedTests.csproj

Co-authored-by: Andrew Lock <[email protected]>
bouwkast and others added 14 commits August 8, 2025 17:41
Sometimes it shows up sometimes it don't
We kill the process in that function so that is
probably why.
They end up getting created with whatever
preview .NET 10 version and then end up looking
for that and not finding it when running
within the .NET 8.0 job.

This should force them to build with .NET 8
and then run with .NET 8 (I think)
Attempting to fix issue where it can't find
the correct .NET runtime
@NachoEchevarria NachoEchevarria force-pushed the dotnet10/UpdateToPreview branch from 262574a to 225d52d Compare August 8, 2025 15:41
@andrewlock andrewlock force-pushed the dotnet10/UpdateToPreview branch from 7f334ea to a0e0031 Compare August 12, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants