Add `DOTNET_ROOT` values for windows integration tests #7346

andrewlock · 2025-08-05T16:19:58Z

Summary of changes

Add DOTNET_ROOT values for Windows integration tests

Reason for change

We think that missing these values is causing failures in the .NET 10 update branch. These should be set in the VMs, but until they are, set them here for now. If merging this to .NET 10 solves the issue, we know the VM fix will too.

Implementation details

Add the variables that control .NET lookup-paths

Test coverage

If the tests pass (and pass in the .NET 10 branch too) then we can merge it. Alternatively, we could just include this in the .NET 10 branch, and update the VMs

Other details

…Core5/Samples.Security.AspNetCore5.csproj Co-authored-by: Andrew Lock <[email protected]>

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Co-authored-by: Andrew Lock <[email protected]>

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Co-authored-by: Andrew Lock <[email protected]>

Sometimes it shows up sometimes it don't We kill the process in that function so that is probably why.

They end up getting created with whatever preview .NET 10 version and then end up looking for that and not finding it when running within the .NET 8.0 job. This should force them to build with .NET 8 and then run with .NET 8 (I think)

This reverts commit c3dd3d3.

This reverts commit d526168.

Attempting to fix issue where it can't find the correct .NET runtime

pr-commenter · 2025-08-05T17:21:16Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7346 compared to master:

1 benchmarks are faster, with geometric mean 1.155
2 benchmarks are slower, with geometric mean 1.593
7 benchmarks have fewer allocations
4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.1 KB	5.98 KB	-123 B	-2.02%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	10.8μs	59.3ns	330ns	0	0	0	5.49 KB
master	`StartStopWithChild`	netcoreapp3.1	13.8μs	55.6ns	215ns	0	0	0	5.7 KB
master	`StartStopWithChild`	net472	22.1μs	113ns	660ns	0.982	0.327	0.109	6.1 KB
#7346	`StartStopWithChild`	net6.0	10.7μs	56.8ns	316ns	0	0	0	5.5 KB
#7346	`StartStopWithChild`	netcoreapp3.1	13.7μs	72.9ns	372ns	0	0	0	5.68 KB
#7346	`StartStopWithChild`	net472	22.3μs	120ns	637ns	0.95	0.422	0.106	5.98 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	936μs	129ns	498ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.04ms	425ns	1.64μs	2.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.2ms	53ns	198ns	3.35 KB
#7346	`WriteAndFlushEnrichedTraces`	net6.0	944μs	389ns	1.46μs	2.7 KB
#7346	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.01ms	74.8ns	270ns	2.7 KB
#7346	`WriteAndFlushEnrichedTraces`	net472	1.22ms	84.9ns	329ns	3.35 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	340μs	1.53μs	5.92μs	0	0	198.41 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	521μs	489ns	1.83μs	0	0	206.17 KB
master	`AllCycleSimpleBody`	net472	451μs	125ns	485ns	37.9	2.23	246.64 KB
master	`AllCycleMoreComplexBody`	net6.0	347μs	1.83μs	8.17μs	0	0	201.91 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	498μs	2.06μs	7.98μs	0	0	209.58 KB
master	`AllCycleMoreComplexBody`	net472	459μs	388ns	1.5μs	37.9	2.23	250.15 KB
master	`ObjectExtractorSimpleBody`	net6.0	319ns	1.7ns	9ns	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	406ns	2.14ns	11.3ns	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	301ns	0.125ns	0.484ns	0.0438	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.42μs	10.4ns	40.2ns	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.85μs	4.96ns	19.2ns	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.7μs	2.13ns	7.98ns	0.572	0	3.8 KB
#7346	`AllCycleSimpleBody`	net6.0	336μs	1.59μs	6.74μs	0	0	198.41 KB
#7346	`AllCycleSimpleBody`	netcoreapp3.1	499μs	1.95μs	7.53μs	0	0	206.17 KB
#7346	`AllCycleSimpleBody`	net472	447μs	125ns	451ns	37.9	2.23	246.64 KB
#7346	`AllCycleMoreComplexBody`	net6.0	342μs	1.44μs	5.56μs	0	0	201.91 KB
#7346	`AllCycleMoreComplexBody`	netcoreapp3.1	503μs	2.19μs	8.5μs	0	0	209.58 KB
#7346	`AllCycleMoreComplexBody`	net472	457μs	50.7ns	183ns	37.9	2.23	250.15 KB
#7346	`ObjectExtractorSimpleBody`	net6.0	325ns	1.69ns	8.63ns	0	0	280 B
#7346	`ObjectExtractorSimpleBody`	netcoreapp3.1	420ns	2.22ns	11.7ns	0	0	272 B
#7346	`ObjectExtractorSimpleBody`	net472	300ns	0.0397ns	0.143ns	0.0438	0	281 B
#7346	`ObjectExtractorMoreComplexBody`	net6.0	6.41μs	3.54ns	13.7ns	0	0	3.78 KB
#7346	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.66μs	38.5ns	163ns	0	0	3.69 KB
#7346	`ObjectExtractorMoreComplexBody`	net472	6.72μs	3.28ns	12.3ns	0.574	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EncodeArgs`	net6.0	77.2μs	106ns	410ns	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	98.9μs	194ns	725ns	0	32.4 KB
master	`EncodeArgs`	net472	109μs	13.4ns	51.7ns	4.9	32.51 KB
master	`EncodeLegacyArgs`	net6.0	147μs	37.7ns	146ns	0	2.14 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	198μs	600ns	2.32μs	0	2.14 KB
master	`EncodeLegacyArgs`	net472	261μs	26.7ns	96.3ns	0	2.17 KB
#7346	`EncodeArgs`	net6.0	77.9μs	245ns	949ns	0	32.4 KB
#7346	`EncodeArgs`	netcoreapp3.1	97.8μs	167ns	647ns	0	32.4 KB
#7346	`EncodeArgs`	net472	108μs	13.1ns	50.8ns	4.89	32.51 KB
#7346	`EncodeLegacyArgs`	net6.0	144μs	58.6ns	227ns	0	2.15 KB
#7346	`EncodeLegacyArgs`	netcoreapp3.1	199μs	108ns	404ns	0	2.14 KB
#7346	`EncodeLegacyArgs`	net472	262μs	75.3ns	292ns	0	2.16 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7346

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1	2.081	416,439.01	866,700.75

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`RunWafRealisticBenchmark`	net6.0	401μs	150ns	580ns	4.56 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	416μs	100ns	375ns	4.48 KB
master	`RunWafRealisticBenchmark`	net472	437μs	53.2ns	206ns	4.66 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	293μs	54.1ns	210ns	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	300μs	136ns	511ns	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	314μs	38.1ns	148ns	2.29 KB
#7346	`RunWafRealisticBenchmark`	net6.0	401μs	62.8ns	243ns	4.55 KB
#7346	`RunWafRealisticBenchmark`	netcoreapp3.1	821μs	13.4μs	134μs	4.48 KB
#7346	`RunWafRealisticBenchmark`	net472	469μs	60.5ns	234ns	4.65 KB
#7346	`RunWafRealisticBenchmarkWithAttack`	net6.0	293μs	79ns	306ns	2.24 KB
#7346	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	304μs	248ns	959ns	2.22 KB
#7346	`RunWafRealisticBenchmarkWithAttack`	net472	313μs	34.3ns	133ns	2.29 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	61.2μs	60.4ns	226ns	14.52 KB
master	`SendRequest`	netcoreapp3.1	70.6μs	77.9ns	302ns	17.42 KB
master	`SendRequest`	net472	0.018ns	0.002ns	0.00774ns	0 b
#7346	`SendRequest`	net6.0	61.2μs	183ns	686ns	14.52 KB
#7346	`SendRequest`	netcoreapp3.1	69.9μs	212ns	795ns	17.42 KB
#7346	`SendRequest`	net472	0.0227ns	0.00197ns	0.00762ns	0 b

Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1	0 b	1 B	1 B	∞

Fewer allocations 🎉 in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0	3 B	1 B	-2 B	-66.67%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`OriginalCharSlice`	net6.0	1.88ms	6.22μs	24.1μs	0	640.01 KB
master	`OriginalCharSlice`	netcoreapp3.1	2.13ms	8.16μs	31.6μs	0	640 KB
master	`OriginalCharSlice`	net472	2.69ms	334ns	1.2μs	100	641.95 KB
master	`OptimizedCharSlice`	net6.0	1.36ms	259ns	1μs	0	7 B
master	`OptimizedCharSlice`	netcoreapp3.1	1.72ms	558ns	2.16μs	0	1 B
master	`OptimizedCharSlice`	net472	1.95ms	875ns	3.39μs	0	0 b
master	`OptimizedCharSliceWithPool`	net6.0	818μs	157ns	567ns	0	3 B
master	`OptimizedCharSliceWithPool`	netcoreapp3.1	802μs	84.2ns	326ns	0	0 b
master	`OptimizedCharSliceWithPool`	net472	1.14ms	78ns	302ns	0	0 b
#7346	`OriginalCharSlice`	net6.0	1.89ms	2.52μs	9.75μs	0	640.01 KB
#7346	`OriginalCharSlice`	netcoreapp3.1	2.1ms	8.61μs	33.4μs	0	640 KB
#7346	`OriginalCharSlice`	net472	2.63ms	189ns	681ns	100	641.95 KB
#7346	`OptimizedCharSlice`	net6.0	1.39ms	512ns	1.84μs	0	7 B
#7346	`OptimizedCharSlice`	netcoreapp3.1	1.77ms	302ns	1.17μs	0	1 B
#7346	`OptimizedCharSlice`	net472	1.93ms	329ns	1.27μs	0	0 b
#7346	`OptimizedCharSliceWithPool`	net6.0	798μs	16.3ns	63.2ns	0	1 B
#7346	`OptimizedCharSliceWithPool`	netcoreapp3.1	840μs	20.7ns	74.6ns	0	1 B
#7346	`OptimizedCharSliceWithPool`	net472	1.17ms	21ns	81.3ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7346

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	1.219	656,439.73	800,462.50

Faster 🎉 in #7346

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	1.155	957,252.90	828,858.48

More allocations ⚠️ in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	42 KB	42.76 KB	765 B	1.82%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.85 KB	42.19 KB	339 B	0.81%

Fewer allocations 🎉 in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	56.43 KB	55.9 KB	-526 B	-0.93%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	659μs	1.89μs	7.3μs	0	0	41.85 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	1.88μs	7.3μs	0	0	42 KB
master	`WriteAndFlushEnrichedTraces`	net472	969μs	5.4μs	36.2μs	8.93	4.46	56.43 KB
#7346	`WriteAndFlushEnrichedTraces`	net6.0	643μs	648ns	2.43μs	0	0	42.19 KB
#7346	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	768μs	4.91μs	48.6μs	0	0	42.76 KB
#7346	`WriteAndFlushEnrichedTraces`	net472	828μs	1.4μs	5.24μs	4.46	0	55.9 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.94μs	6.08ns	22.7ns	0	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.58μs	12.5ns	51.6ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.84μs	8.7ns	32.5ns	0.15	0.015	987 B
#7346	`ExecuteNonQuery`	net6.0	1.86μs	0.581ns	2.25ns	0	0	1.02 KB
#7346	`ExecuteNonQuery`	netcoreapp3.1	2.48μs	7.82ns	30.3ns	0	0	1.02 KB
#7346	`ExecuteNonQuery`	net472	2.92μs	14.7ns	65.6ns	0.151	0.0137	988 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.73μs	0.738ns	2.86ns	0	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	2.4μs	8.87ns	34.4ns	0	1.03 KB
master	`CallElasticsearch`	net472	3.5μs	2.95ns	10.2ns	0.157	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.8μs	8.38ns	33.5ns	0	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.47μs	7.23ns	28ns	0	1.08 KB
master	`CallElasticsearchAsync`	net472	3.61μs	0.583ns	2.1ns	0.162	1.1 KB
#7346	`CallElasticsearch`	net6.0	1.81μs	5.62ns	21.8ns	0	1.03 KB
#7346	`CallElasticsearch`	netcoreapp3.1	2.41μs	7.44ns	28.8ns	0	1.03 KB
#7346	`CallElasticsearch`	net472	3.45μs	4.77ns	18.5ns	0.154	1.04 KB
#7346	`CallElasticsearchAsync`	net6.0	1.85μs	8.56ns	33.1ns	0	1.01 KB
#7346	`CallElasticsearchAsync`	netcoreapp3.1	2.61μs	9.85ns	36.9ns	0	1.08 KB
#7346	`CallElasticsearchAsync`	net472	3.84μs	4.63ns	17.9ns	0.172	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.95μs	3.2ns	12.4ns	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	2.48μs	4.14ns	16ns	0	952 B
master	`ExecuteAsync`	net472	2.61μs	3ns	11.6ns	0.142	915 B
#7346	`ExecuteAsync`	net6.0	1.87μs	7.53ns	29.2ns	0	952 B
#7346	`ExecuteAsync`	netcoreapp3.1	2.36μs	10.9ns	42.1ns	0	952 B
#7346	`ExecuteAsync`	net472	2.62μs	1.84ns	6.87ns	0.143	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	7.42μs	11.2ns	43.2ns	0	2.36 KB
master	`SendAsync`	netcoreapp3.1	8.89μs	35.6ns	138ns	0	2.9 KB
master	`SendAsync`	net472	12μs	6.76ns	25.3ns	0.48	3.18 KB
#7346	`SendAsync`	net6.0	7.06μs	3.99ns	14.4ns	0	2.36 KB
#7346	`SendAsync`	netcoreapp3.1	8.57μs	26.8ns	104ns	0	2.9 KB
#7346	`SendAsync`	net472	12.5μs	10.1ns	39.1ns	0.503	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	256.51 KB	276.2 KB	19.69 KB	7.68%

Fewer allocations 🎉 in #7346

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	44.18 KB	43.64 KB	-536 B	-1.21%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	280.11 KB	259.66 KB	-20.45 KB	-7.30%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	65.54 KB	57.34 KB	-8.19 KB	-12.50%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	52.03 KB	43.83 KB	-8.2 KB	-15.76%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	42μs	196ns	785ns	44.18 KB
master	`StringConcatBenchmark`	netcoreapp3.1	48.3μs	283ns	2.33μs	52.03 KB
master	`StringConcatBenchmark`	net472	57.9μs	142ns	533ns	65.54 KB
master	`StringConcatAspectBenchmark`	net6.0	460μs	1.55μs	7.73μs	256.51 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	538μs	1.1μs	3.95μs	280.11 KB
master	`StringConcatAspectBenchmark`	net472	403μs	2.23μs	16.4μs	286.72 KB
#7346	`StringConcatBenchmark`	net6.0	45.3μs	261ns	1.95μs	43.64 KB
#7346	`StringConcatBenchmark`	netcoreapp3.1	50μs	310ns	2.91μs	43.83 KB
#7346	`StringConcatBenchmark`	net472	57.1μs	212ns	763ns	57.34 KB
#7346	`StringConcatAspectBenchmark`	net6.0	496μs	1.96μs	7.06μs	276.2 KB
#7346	`StringConcatAspectBenchmark`	netcoreapp3.1	517μs	1.3μs	4.68μs	259.66 KB
#7346	`StringConcatAspectBenchmark`	net472	407μs	2.12μs	10.6μs	286.72 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.61μs	13.2ns	63.1ns	0	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	3.44μs	12.4ns	47.8ns	0	1.7 KB
master	`EnrichedLog`	net472	4.04μs	2.83ns	10.9ns	0.242	1.64 KB
#7346	`EnrichedLog`	net6.0	2.57μs	11.8ns	45.8ns	0	1.7 KB
#7346	`EnrichedLog`	netcoreapp3.1	3.54μs	6.44ns	24.9ns	0	1.7 KB
#7346	`EnrichedLog`	net472	3.97μs	3.44ns	13.3ns	0.257	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	124μs	87.5ns	339ns	4.31 KB
master	`EnrichedLog`	netcoreapp3.1	127μs	96.9ns	362ns	4.31 KB
master	`EnrichedLog`	net472	167μs	39.2ns	147ns	4.52 KB
#7346	`EnrichedLog`	net6.0	123μs	63.2ns	219ns	4.31 KB
#7346	`EnrichedLog`	netcoreapp3.1	127μs	72.8ns	252ns	4.31 KB
#7346	`EnrichedLog`	net472	167μs	192ns	745ns	4.52 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.86μs	6.89ns	25.8ns	0	2.26 KB
master	`EnrichedLog`	netcoreapp3.1	6.64μs	20.2ns	78ns	0	2.26 KB
master	`EnrichedLog`	net472	7.49μs	5.03ns	19.5ns	0.301	2.08 KB
#7346	`EnrichedLog`	net6.0	4.94μs	14.2ns	55.1ns	0	2.26 KB
#7346	`EnrichedLog`	netcoreapp3.1	6.61μs	9.63ns	37.3ns	0	2.26 KB
#7346	`EnrichedLog`	net472	7.53μs	10.2ns	39.6ns	0.302	2.08 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.99μs	1ns	3.87ns	0	1.2 KB
master	`SendReceive`	netcoreapp3.1	2.62μs	10.6ns	39.5ns	0	1.2 KB
master	`SendReceive`	net472	3.2μs	2.47ns	9.26ns	0.19	1.2 KB
#7346	`SendReceive`	net6.0	2.05μs	4.69ns	18.2ns	0	1.2 KB
#7346	`SendReceive`	netcoreapp3.1	2.69μs	11.5ns	44.4ns	0	1.2 KB
#7346	`SendReceive`	net472	3.19μs	1.79ns	6.91ns	0.176	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.09μs	1.51ns	5.44ns	0	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	5.67μs	18.3ns	71ns	0	1.63 KB
master	`EnrichedLog`	net472	6.43μs	9.75ns	37.8ns	0.29	2.03 KB
#7346	`EnrichedLog`	net6.0	4.13μs	8.22ns	31.8ns	0	1.58 KB
#7346	`EnrichedLog`	netcoreapp3.1	5.43μs	5.57ns	20.8ns	0	1.63 KB
#7346	`EnrichedLog`	net472	6.44μs	7.05ns	27.3ns	0.291	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	757ns	3.15ns	11.8ns	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	960ns	4.6ns	17.8ns	0	576 B
master	`StartFinishSpan`	net472	940ns	0.303ns	1.17ns	0.0892	578 B
master	`StartFinishScope`	net6.0	938ns	5.01ns	24ns	0	696 B
master	`StartFinishScope`	netcoreapp3.1	1.14μs	5.43ns	21.7ns	0	696 B
master	`StartFinishScope`	net472	1.15μs	1ns	3.75ns	0.0998	658 B
#7346	`StartFinishSpan`	net6.0	777ns	3.83ns	17.6ns	0	576 B
#7346	`StartFinishSpan`	netcoreapp3.1	931ns	4.89ns	24.9ns	0	576 B
#7346	`StartFinishSpan`	net472	956ns	0.397ns	1.43ns	0.0909	578 B
#7346	`StartFinishScope`	net6.0	879ns	0.234ns	0.908ns	0	696 B
#7346	`StartFinishScope`	netcoreapp3.1	1.14μs	6.12ns	31.2ns	0	696 B
#7346	`StartFinishScope`	net472	1.12μs	0.424ns	1.64ns	0.101	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.07μs	0.392ns	1.52ns	0	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.38μs	2.77ns	10.7ns	0	696 B
master	`RunOnMethodBegin`	net472	1.4μs	1.27ns	4.59ns	0.0982	658 B
#7346	`RunOnMethodBegin`	net6.0	1.07μs	0.926ns	3.59ns	0	696 B
#7346	`RunOnMethodBegin`	netcoreapp3.1	1.4μs	6.86ns	29.1ns	0	696 B
#7346	`RunOnMethodBegin`	net472	1.43μs	0.676ns	2.53ns	0.1	658 B

…eview

datadog-official · 2025-08-06T11:50:31Z

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog)
Expected exit code: 0, actual exit code: 139.
View all

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c2b8915 | Docs | Was this helpful? Give us feedback!}

…eview

dd-trace-dotnet-ci-bot · 2025-08-06T16:19:35Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (71ms)  : 71, 72
     .   : milestone, 71,

    section Baseline
    This PR (7346) - mean (69ms)  : 63, 76
     .   : milestone, 69,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (1,050ms)  : 1024, 1076
     .   : milestone, 1050,
    master - mean (1,046ms)  : 1023, 1070
     .   : milestone, 1046,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (107ms)  : 106, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7346) - mean (107ms)  : 103, 110
     .   : milestone, 107,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (728ms)  : 714, 742
     .   : milestone, 728,
    master - mean (725ms)  : 711, 740
     .   : milestone, 725,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7346) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (694ms)  : 680, 708
     .   : milestone, 694,
    master - mean (691ms)  : 674, 709
     .   : milestone, 691,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (93ms)  : 92, 95
     .   : milestone, 93,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7346) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (626ms)  : 616, 636
     .   : milestone, 626,
    master - mean (626ms)  : 618, 634
     .   : milestone, 626,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (211ms)  : 207, 216
     .   : milestone, 211,
    master - mean (213ms)  : 208, 217
     .   : milestone, 213,

    section Baseline
    This PR (7346) - mean (208ms)  : 202, 215
     .   : milestone, 208,
    master - mean (209ms)  : 203, 214
     .   : milestone, 209,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (1,223ms)  : 1196, 1249
     .   : milestone, 1223,
    master - mean (1,224ms)  : 1190, 1257
     .   : milestone, 1224,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (299ms)  : 292, 305
     .   : milestone, 299,
    master - mean (307ms)  : 300, 313
     .   : milestone, 307,

    section Baseline
    This PR (7346) - mean (298ms)  : 291, 304
     .   : milestone, 298,
    master - mean (306ms)  : 299, 312
     .   : milestone, 306,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (981ms)  : 944, 1017
     .   : milestone, 981,
    master - mean (1,002ms)  : 980, 1024
     .   : milestone, 1002,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (293ms)  : 288, 298
     .   : milestone, 293,
    master - mean (296ms)  : 290, 301
     .   : milestone, 296,

    section Baseline
    This PR (7346) - mean (293ms)  : 288, 298
     .   : milestone, 293,
    master - mean (294ms)  : 288, 300
     .   : milestone, 294,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (962ms)  : 937, 986
     .   : milestone, 962,
    master - mean (969ms)  : 947, 992
     .   : milestone, 969,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7346) - mean (293ms)  : 287, 299
     .   : milestone, 293,
    master - mean (295ms)  : 288, 301
     .   : milestone, 295,

    section Baseline
    This PR (7346) - mean (292ms)  : 286, 298
     .   : milestone, 292,
    master - mean (293ms)  : 286, 300
     .   : milestone, 293,

    section CallTarget+Inlining+NGEN
    This PR (7346) - mean (879ms)  : 832, 926
     .   : milestone, 879,
    master - mean (880ms)  : 849, 911
     .   : milestone, 880,

NachoEchevarria and others added 30 commits July 30, 2025 10:45

Add .net 10 to samples

11cb4f6

Fixes required to compile samples locally

e982fc9

update pipeline and docker files

7d0db2d

install dotnet preview manually

9c17007

undo

620b2b4

Avoid compilation errors

7447407

Fix compilation errors

ce89ba1

fix compile errors

4616b86

Update tracer/test/test-applications/security/Samples.Security.AspNet…

ce71421

…Core5/Samples.Security.AspNetCore5.csproj Co-authored-by: Andrew Lock <[email protected]>

Update tracer/test/test-applications/integrations/Samples.Instrumente…

93e6f95

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Update tracer/test/test-applications/integrations/Samples.Instrumente…

0ae9654

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Update tracer/test/test-applications/integrations/Samples.Instrumente…

cf99941

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Update tracer/src/Datadog.Trace.Coverage.collector/FiltersHelper.cs

3ae901c

Co-authored-by: Andrew Lock <[email protected]>

Update tracer/test/test-applications/integrations/Samples.Instrumente…

a01f565

…dTests/Samples.InstrumentedTests.csproj Co-authored-by: Andrew Lock <[email protected]>

Update tracer/src/Datadog.Trace.Coverage.collector/FiltersHelper.cs

7d0a4dd

Co-authored-by: Andrew Lock <[email protected]>

update Samples security sample, use latest .net10 packages

d4949d7

Remove <NoWarn>NU1510</NoWarn>

b486c13

modify sha

ca2d07b

install .net 10 by script

4ef5e88

update build.ps1

810ca6e

update build project

94951dc

update script

bbd911b

Fix error in script

58b06cc

update build.ps1

7bce71d

update script

f12e23a

Fix

919ecfc

another try

405c2ad

Another try

1fad277

update pipeline sdk short name

f3320ea

Launch .Net10 tests

b3343d2

NachoEchevarria and others added 15 commits July 30, 2025 17:42

Merge branch 'master' into dotnet10/UpdateToPreview

0b02cd3

Atempt to fix Azure Functions for .NET 10

97cd799

Fix flaky UtcNow_IsMonotonic test

68c4e19

Sqlite error in Alpine

537f391

Filter out the ExitApp Span

b994e19

Sometimes it shows up sometimes it don't We kill the process in that function so that is probably why.

Merge branch 'master' into dotnet10/UpdateToPreview

3054b43

Undo Sqlite error in Alpine

144b672

Target .NET 8.0 for instrumentation tests

d526168

They end up getting created with whatever preview .NET 10 version and then end up looking for that and not finding it when running within the .NET 8.0 job. This should force them to build with .NET 8 and then run with .NET 8 (I think)

Try to make global.json to use .NET 8

c3dd3d3

Revert "Try to make global.json to use .NET 8"

bd4513a

This reverts commit c3dd3d3.

Revert "Target .NET 8.0 for instrumentation tests"

f93064c

This reverts commit d526168.

Try a different way to get .NET 8 over .NET 10

632c5e0

Merge branch 'master' into dotnet10/UpdateToPreview

97c4111

Fix BaggageInSpanTags test

263840f

Swap publish to be self contained

ba8c5ab

Attempting to fix issue where it can't find the correct .NET runtime

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 5, 2025

andrewlock changed the base branch from master to dotnet10/UpdateToPreview August 5, 2025 16:21

andrewlock force-pushed the andrew/ci/explicitly-set-dotnet-root branch from c806665 to bea3247 Compare August 6, 2025 10:21

Merge remote-tracking branch 'origin/master' into dotnet10/UpdateToPr…

64ca647

…eview

andrewlock force-pushed the andrew/ci/explicitly-set-dotnet-root branch from bea3247 to 8b7a019 Compare August 6, 2025 10:39

Merge branch 'master' into dotnet10/UpdateToPreview

1857f59

andrewlock added 3 commits August 6, 2025 16:09

Merge remote-tracking branch 'origin/master' into dotnet10/UpdateToPr…

7ba332f

…eview

Add DOTNET_ROOT values for windows integration tests

45af633

try-fix-escaping

c2b8915

andrewlock force-pushed the andrew/ci/explicitly-set-dotnet-root branch from 8b7a019 to c2b8915 Compare August 6, 2025 15:09

NachoEchevarria force-pushed the dotnet10/UpdateToPreview branch from 262574a to 225d52d Compare August 8, 2025 15:41

andrewlock force-pushed the dotnet10/UpdateToPreview branch from 7f334ea to a0e0031 Compare August 12, 2025 16:05

Add DOTNET_ROOT values for windows integration tests #7346

Are you sure you want to change the base?

Add DOTNET_ROOT values for windows integration tests #7346

Uh oh!

Conversation

andrewlock commented Aug 5, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter bot commented Aug 5, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

Fewer allocations 🎉 in #7346

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #7346

Raw results

Raw results

More allocations ⚠️ in #7346

Fewer allocations 🎉 in #7346

Raw results

Slower ⚠️ in #7346

Faster 🎉 in #7346

More allocations ⚠️ in #7346

Fewer allocations 🎉 in #7346

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #7346

Fewer allocations 🎉 in #7346

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

datadog-official bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

dd-trace-dotnet-ci-bot bot commented Aug 6, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

Uh oh!

Add `DOTNET_ROOT` values for windows integration tests #7346

Add `DOTNET_ROOT` values for windows integration tests #7346

datadog-official bot commented Aug 6, 2025 •

edited

Loading