Skip to content

Small IPC changes #7352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Small IPC changes #7352

wants to merge 2 commits into from

Conversation

tonyredondo
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (71ms)  : 71, 72
     .   : milestone, 71,

    section Baseline
    This PR (7352) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (1,051ms)  : 1020, 1081
     .   : milestone, 1051,
    master - mean (1,046ms)  : 1023, 1070
     .   : milestone, 1046,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (108ms)  : 107, 109
     .   : milestone, 108,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7352) - mean (106ms)  : 104, 108
     .   : milestone, 106,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (727ms)  : 711, 743
     .   : milestone, 727,
    master - mean (725ms)  : 711, 740
     .   : milestone, 725,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (94ms)  : 94, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7352) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (685ms)  : 665, 704
     .   : milestone, 685,
    master - mean (691ms)  : 674, 709
     .   : milestone, 691,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (93ms)  : 92, 95
     .   : milestone, 93,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7352) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (623ms)  : 612, 634
     .   : milestone, 623,
    master - mean (626ms)  : 618, 634
     .   : milestone, 626,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (210ms)  : 206, 214
     .   : milestone, 210,
    master - mean (213ms)  : 208, 217
     .   : milestone, 213,

    section Baseline
    This PR (7352) - mean (208ms)  : 202, 214
     .   : milestone, 208,
    master - mean (209ms)  : 203, 214
     .   : milestone, 209,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (1,219ms)  : 1191, 1247
     .   : milestone, 1219,
    master - mean (1,224ms)  : 1190, 1257
     .   : milestone, 1224,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (297ms)  : 292, 302
     .   : milestone, 297,
    master - mean (307ms)  : 300, 313
     .   : milestone, 307,

    section Baseline
    This PR (7352) - mean (299ms)  : 293, 305
     .   : milestone, 299,
    master - mean (306ms)  : 299, 312
     .   : milestone, 306,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (975ms)  : 949, 1000
     .   : milestone, 975,
    master - mean (1,002ms)  : 980, 1024
     .   : milestone, 1002,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (294ms)  : 286, 301
     .   : milestone, 294,
    master - mean (296ms)  : 290, 301
     .   : milestone, 296,

    section Baseline
    This PR (7352) - mean (292ms)  : 286, 298
     .   : milestone, 292,
    master - mean (294ms)  : 288, 300
     .   : milestone, 294,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (962ms)  : 934, 989
     .   : milestone, 962,
    master - mean (969ms)  : 947, 992
     .   : milestone, 969,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7352) - mean (291ms)  : 285, 298
     .   : milestone, 291,
    master - mean (295ms)  : 288, 301
     .   : milestone, 295,

    section Baseline
    This PR (7352) - mean (291ms)  : 283, 299
     .   : milestone, 291,
    master - mean (293ms)  : 286, 300
     .   : milestone, 293,

    section CallTarget+Inlining+NGEN
    This PR (7352) - mean (869ms)  : 845, 893
     .   : milestone, 869,
    master - mean (880ms)  : 849, 911
     .   : milestone, 880,

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant