Skip to content

Conversation

@dudikeleti
Copy link
Contributor

Summary of changes

This PR finalizes the work introduced in Debugger In-Product Enablement and RC Multi-Config Support by integrating the new debugger dynamic configuration keys into both the dynamic configuration source and the APM tracing merger.

Test coverage

DebuggerManagerDynamicTests

@dudikeleti dudikeleti requested review from a team as code owners October 1, 2025 01:19
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7595) - mean (68ms)  : 67, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (1,049ms)  : 1005, 1093
     .   : milestone, 1049,
    master - mean (1,049ms)  : 1005, 1093
     .   : milestone, 1049,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7595) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (106ms)  : 104, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (745ms)  : 719, 772
     .   : milestone, 745,
    master - mean (744ms)  : 721, 766
     .   : milestone, 744,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (101ms)  : 100, 101
     .   : milestone, 101,
    master - mean (101ms)  : 100, 102
     .   : milestone, 101,

    section Baseline
    This PR (7595) - mean (100ms)  : 98, 102
     .   : milestone, 100,
    master - mean (100ms)  : 97, 103
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (774ms)  : 725, 822
     .   : milestone, 774,
    master - mean (771ms)  : 713, 828
     .   : milestone, 771,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (93ms)  : 91, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7595) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (660ms)  : 646, 673
     .   : milestone, 660,
    master - mean (662ms)  : 645, 680
     .   : milestone, 662,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (200ms)  : 195, 206
     .   : milestone, 200,
    master - mean (201ms)  : 196, 206
     .   : milestone, 201,

    section Baseline
    This PR (7595) - mean (197ms)  : 191, 204
     .   : milestone, 197,
    master - mean (198ms)  : 193, 202
     .   : milestone, 198,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (1,173ms)  : 1123, 1224
     .   : milestone, 1173,
    master - mean (1,190ms)  : 1109, 1270
     .   : milestone, 1190,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (284ms)  : 277, 291
     .   : milestone, 284,
    master - mean (285ms)  : 278, 292
     .   : milestone, 285,

    section Baseline
    This PR (7595) - mean (284ms)  : 277, 290
     .   : milestone, 284,
    master - mean (285ms)  : 277, 294
     .   : milestone, 285,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (955ms)  : 915, 994
     .   : milestone, 955,
    master - mean (950ms)  : 905, 994
     .   : milestone, 950,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (288ms)  : 282, 294
     .   : milestone, 288,
    master - mean (287ms)  : 280, 295
     .   : milestone, 287,

    section Baseline
    This PR (7595) - mean (287ms)  : 279, 295
     .   : milestone, 287,
    master - mean (288ms)  : 280, 296
     .   : milestone, 288,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (1,003ms)  : 954, 1053
     .   : milestone, 1003,
    master - mean (1,012ms)  : 974, 1049
     .   : milestone, 1012,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7595) - mean (279ms)  : 269, 289
     .   : milestone, 279,
    master - mean (275ms)  : 269, 282
     .   : milestone, 275,

    section Baseline
    This PR (7595) - mean (275ms)  : 268, 282
     .   : milestone, 275,
    master - mean (276ms)  : 270, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7595) - mean (865ms)  : 839, 890
     .   : milestone, 865,
    master - mean (871ms)  : 847, 896
     .   : milestone, 871,

Loading

@dudikeleti dudikeleti enabled auto-merge (squash) October 1, 2025 08:18
@dudikeleti dudikeleti merged commit 99cb14c into master Oct 1, 2025
157 checks passed
@dudikeleti dudikeleti deleted the dudik/fix-debugger-dynamic-configuration branch October 1, 2025 12:09
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants