Add process tags to runtime metrics & dynamic instrumentation metric probes #7871
+155
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… probes # Conflicts: # tracer/src/Datadog.Trace/Debugger/DebuggerFactory.cs # tracer/src/Datadog.Trace/TracerManagerFactory.cs
vandonr
force-pushed
the
vandonr/process
branch
from
6dfff5b to
efa9f9d
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7871) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (7871) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7871) - mean (1,011ms) : 972, 1049
master - mean (1,007ms) : 966, 1048
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (107ms) : 104, 109
master - mean (106ms) : 103, 109
section Bailout
This PR (7871) - mean (108ms) : 106, 109
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (7871) - mean (738ms) : 665, 811
master - mean (723ms) : 668, 779
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (94ms) : 92, 96
master - mean (93ms) : 91, 95
section Bailout
This PR (7871) - mean (95ms) : 94, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7871) - mean (713ms) : 676, 750
master - mean (703ms) : 657, 749
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (92ms) : 90, 94
master - mean (92ms) : 89, 94
section Bailout
This PR (7871) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7871) - mean (633ms) : 618, 649
master - mean (632ms) : 616, 647
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (194ms) : 189, 199
master - mean (193ms) : 189, 197
section Bailout
This PR (7871) - mean (197ms) : 193, 202
master - mean (196ms) : 194, 198
section CallTarget+Inlining+NGEN
This PR (7871) - mean (1,123ms) : 1060, 1187
master - mean (1,114ms) : 1064, 1164
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (277ms) : 272, 281
master - mean (276ms) : 271, 281
section Bailout
This PR (7871) - mean (277ms) : 273, 281
master - mean (276ms) : 273, 280
section CallTarget+Inlining+NGEN
This PR (7871) - mean (923ms) : 867, 978
master - mean (921ms) : 865, 976
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (271ms) : 265, 277
master - mean (271ms) : 264, 278
section Bailout
This PR (7871) - mean (270ms) : 266, 274
master - mean (270ms) : 267, 273
section CallTarget+Inlining+NGEN
This PR (7871) - mean (927ms) : 883, 971
master - mean (930ms) : 894, 966
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7871) - mean (270ms) : 264, 275
master - mean (269ms) : 264, 275
section Bailout
This PR (7871) - mean (270ms) : 265, 274
master - mean (269ms) : 265, 273
section CallTarget+Inlining+NGEN
This PR (7871) - mean (826ms) : 804, 848
master - mean (821ms) : 802, 840
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
add process tags as constant tags for both runtime metrics and the metrics sent by dynamic instrumentation probes
Reason for change
AIDM-195
Implementation details
Test coverage
Will append existing integration tests
Other details