Skip to content

Conversation

@tonyredondo
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 4 Tests failed

Injection from Datadog.Trace.ClrProfiler.IntegrationTests.CI.SeleniumTests (Datadog) (Fix with Cursor)

Verified path: D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\SeleniumTests.Injection_all_versions.verified.txt
Injection from Datadog.Trace.ClrProfiler.IntegrationTests.CI.SeleniumTests (Datadog) (Fix with Cursor)

Verified path: D:\a\_work\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\SeleniumTests.Injection_all_versions.verified.txt
Injection from Datadog.Trace.ClrProfiler.IntegrationTests.CI.SeleniumTests (Datadog) (Fix with Cursor)

Expected collection to contain 1 item(s), but found 0: {empty}..
TestMaxRanges from Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsFullSamplingIastEnabled (Datadog) (Fix with Cursor)
Unable to determine port application is listening on
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fdfacac | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 17, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7960) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.36 ± (68.34 - 68.56) ms68.34 ± (68.31 - 68.52) ms-0.0%
.NET Framework 4.8 - Bailout
duration72.26 ± (72.17 - 72.38) ms72.04 ± (71.97 - 72.20) ms-0.3%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1001.90 ± (1004.29 - 1009.74) ms1008.75 ± (1011.83 - 1019.08) ms+0.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.86 ± (21.82 - 21.89) ms22.05 ± (22.01 - 22.08) ms+0.9%✅⬆️
process.time_to_main_ms78.50 ± (78.39 - 78.62) ms78.93 ± (78.78 - 79.08) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.94 ± (10.93 - 10.94) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms21.72 ± (21.70 - 21.74) ms21.97 ± (21.94 - 22.00) ms+1.2%✅⬆️
process.time_to_main_ms79.77 ± (79.69 - 79.85) ms80.11 ± (79.96 - 80.26) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.96 ± (10.96 - 10.97) MB10.95 ± (10.95 - 10.96) MB-0.1%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms238.76 ± (234.48 - 243.04) ms238.07 ± (233.81 - 242.34) ms-0.3%
process.time_to_main_ms470.07 ± (469.61 - 470.54) ms473.44 ± (472.91 - 473.97) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.16 ± (48.14 - 48.18) MB48.25 ± (48.23 - 48.27) MB+0.2%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%
.NET 6 - Baseline
process.internal_duration_ms20.65 ± (20.62 - 20.67) ms20.56 ± (20.53 - 20.58) ms-0.4%
process.time_to_main_ms68.13 ± (68.02 - 68.25) ms67.95 ± (67.83 - 68.06) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.62) MB10.63 ± (10.63 - 10.64) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.52 ± (20.49 - 20.55) ms20.57 ± (20.55 - 20.60) ms+0.3%✅⬆️
process.time_to_main_ms68.84 ± (68.78 - 68.91) ms69.03 ± (68.97 - 69.09) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.67 ± (10.66 - 10.67) MB10.74 ± (10.73 - 10.74) MB+0.6%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms243.38 ± (241.04 - 245.73) ms241.57 ± (239.21 - 243.93) ms-0.7%
process.time_to_main_ms440.19 ± (439.71 - 440.67) ms442.80 ± (442.33 - 443.27) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.68 ± (48.64 - 48.72) MB48.69 ± (48.66 - 48.72) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%
.NET 8 - Baseline
process.internal_duration_ms18.87 ± (18.85 - 18.89) ms18.83 ± (18.81 - 18.86) ms-0.2%
process.time_to_main_ms67.15 ± (67.04 - 67.26) ms67.11 ± (67.02 - 67.20) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.69) MB7.68 ± (7.68 - 7.69) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms18.84 ± (18.81 - 18.88) ms18.87 ± (18.84 - 18.89) ms+0.1%✅⬆️
process.time_to_main_ms68.41 ± (68.32 - 68.49) ms68.16 ± (68.11 - 68.21) ms-0.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.78 ± (7.77 - 7.80) MB7.72 ± (7.71 - 7.73) MB-0.8%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms178.81 ± (177.79 - 179.82) ms176.73 ± (175.90 - 177.56) ms-1.2%
process.time_to_main_ms425.88 ± (425.21 - 426.55) ms427.21 ± (426.57 - 427.85) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.32 ± (36.29 - 36.35) MB36.27 ± (36.24 - 36.30) MB-0.1%
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.44 ± (192.48 - 193.29) ms192.55 ± (192.34 - 193.09) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration196.57 ± (196.32 - 197.20) ms195.65 ± (195.68 - 196.12) ms-0.5%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1108.14 ± (1109.67 - 1117.15) ms1113.95 ± (1114.69 - 1122.12) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms188.47 ± (188.07 - 188.88) ms187.75 ± (187.38 - 188.12) ms-0.4%
process.time_to_main_ms80.38 ± (80.14 - 80.63) ms80.32 ± (80.09 - 80.55) ms-0.1%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.04 ± (16.01 - 16.06) MB16.18 ± (16.15 - 16.21) MB+0.9%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.6%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms186.71 ± (186.44 - 186.98) ms187.37 ± (187.04 - 187.70) ms+0.4%✅⬆️
process.time_to_main_ms81.18 ± (81.07 - 81.30) ms81.32 ± (81.22 - 81.41) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.12 ± (16.09 - 16.15) MB16.18 ± (16.15 - 16.20) MB+0.4%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.2%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms419.43 ± (416.11 - 422.74) ms422.31 ± (419.09 - 425.53) ms+0.7%✅⬆️
process.time_to_main_ms475.41 ± (474.77 - 476.05) ms474.12 ± (473.50 - 474.74) ms-0.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.63 ± (58.51 - 58.75) MB58.78 ± (58.67 - 58.89) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 30)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.23 ± (191.89 - 192.56) ms192.25 ± (191.93 - 192.56) ms+0.0%✅⬆️
process.time_to_main_ms69.35 ± (69.19 - 69.51) ms69.44 ± (69.28 - 69.59) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.18 ± (16.07 - 16.29) MB16.31 ± (16.21 - 16.40) MB+0.8%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)18 ± (18 - 19)-1.3%
.NET 6 - Bailout
process.internal_duration_ms191.25 ± (190.91 - 191.59) ms191.34 ± (191.08 - 191.60) ms+0.0%✅⬆️
process.time_to_main_ms70.22 ± (70.11 - 70.33) ms70.27 ± (70.16 - 70.38) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.18 ± (16.05 - 16.30) MB15.99 ± (15.83 - 16.15) MB-1.2%
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 19)-2.6%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms450.67 ± (447.64 - 453.71) ms453.04 ± (450.91 - 455.16) ms+0.5%✅⬆️
process.time_to_main_ms444.57 ± (444.07 - 445.08) ms447.03 ± (446.56 - 447.50) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed58.49 ± (58.37 - 58.61) MB58.24 ± (58.13 - 58.34) MB-0.4%
runtime.dotnet.threads.count30 ± (30 - 30)29 ± (29 - 30)-0.3%
.NET 8 - Baseline
process.internal_duration_ms190.31 ± (189.98 - 190.64) ms190.19 ± (189.85 - 190.52) ms-0.1%
process.time_to_main_ms68.94 ± (68.77 - 69.11) ms69.26 ± (69.07 - 69.44) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.78 ± (11.74 - 11.81) MB11.72 ± (11.70 - 11.75) MB-0.5%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.3%
.NET 8 - Bailout
process.internal_duration_ms189.74 ± (189.47 - 190.01) ms189.61 ± (189.29 - 189.92) ms-0.1%
process.time_to_main_ms70.02 ± (69.92 - 70.12) ms70.08 ± (69.96 - 70.19) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.85 ± (11.80 - 11.90) MB11.82 ± (11.79 - 11.85) MB-0.2%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+2.7%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms363.34 ± (361.99 - 364.68) ms363.40 ± (362.01 - 364.78) ms+0.0%✅⬆️
process.time_to_main_ms428.47 ± (427.79 - 429.14) ms430.91 ± (430.30 - 431.52) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed47.93 ± (47.90 - 47.96) MB48.02 ± (47.99 - 48.06) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (7960) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (1,015ms)  : 964, 1067
    master - mean (1,007ms)  : 967, 1047

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (106ms)  : 102, 110
    master - mean (106ms)  : 103, 108

    section Bailout
    This PR (7960) - mean (107ms)  : 105, 109
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (738ms)  : 674, 801
    master - mean (735ms)  : 672, 799

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (93ms)  : 91, 95
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (7960) - mean (94ms)  : 93, 95
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (710ms)  : 673, 746
    master - mean (709ms)  : 672, 747

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (7960) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 92, 95

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (633ms)  : 618, 647
    master - mean (633ms)  : 616, 650

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (193ms)  : 189, 196
    master - mean (193ms)  : 189, 197

    section Bailout
    This PR (7960) - mean (196ms)  : 194, 198
    master - mean (197ms)  : 192, 201

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (1,118ms)  : 1064, 1173
    master - mean (1,113ms)  : 1058, 1169

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (277ms)  : 270, 284
    master - mean (277ms)  : 271, 282

    section Bailout
    This PR (7960) - mean (277ms)  : 273, 281
    master - mean (276ms)  : 273, 279

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (924ms)  : 877, 972
    master - mean (922ms)  : 871, 974

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (7960) - mean (270ms)  : 266, 273
    master - mean (269ms)  : 264, 274

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (927ms)  : 889, 966
    master - mean (923ms)  : 874, 972

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7960) - mean (269ms)  : 264, 274
    master - mean (269ms)  : 264, 274

    section Bailout
    This PR (7960) - mean (269ms)  : 265, 274
    master - mean (269ms)  : 265, 272

    section CallTarget+Inlining+NGEN
    This PR (7960) - mean (824ms)  : 805, 844
    master - mean (822ms)  : 800, 845

Loading

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2025

Benchmarks

Benchmark execution time: 2026-01-09 13:53:59

Comparing candidate commit b86c1b5 in PR branch tony/testoptimization-performance-work with baseline commit c865b1b in branch master.

Found 7 performance improvements and 6 performance regressions! Performance is the same for 163 metrics, 10 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-20253.992op/s; -19278.515op/s] or [-30.894%; -29.406%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-8646.727op/s; -6218.870op/s] or [-8.929%; -6.422%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-77.718ms; -77.594ms] or [-38.755%; -38.693%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 execution_time [+11.705ms; +17.284ms] or [+5.868%; +8.665%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 execution_time [+22.567ms; +28.739ms] or [+11.581%; +14.748%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.403ms; -12.480ms] or [-8.770%; -5.947%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 throughput [+120.430op/s; +139.313op/s] or [+11.367%; +13.150%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-74.605ms; -69.715ms] or [-32.922%; -30.764%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-69.819µs; -63.048µs] or [-6.270%; -5.662%]
  • 🟩 throughput [+54.134op/s; +59.806op/s] or [+6.028%; +6.659%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-1.545ms; -1.151ms] or [-38.948%; -29.023%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 throughput [-37290.089op/s; -24543.356op/s] or [-7.950%; -5.232%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 execution_time [+14.264ms; +17.541ms] or [+7.740%; +9.519%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants