Skip to content

[Dynamic Instrumentation] Disable AppDomain related log flooding on .NET Framework #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GreenMatan merged 1 commit into from
Jan 7, 2026
Merged

[Dynamic Instrumentation] Disable AppDomain related log flooding on .NET Framework #8025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tracer/src/Datadog.Trace/Debugger/Instrumentation/AsyncMethodDebuggerInvoker.SingleProbe.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,14 @@ public static void BeginMethod<TTarget>(TTarget instance, int methodMetadataInde
ref var probeData = ref ProbeDataCollection.Instance.TryCreateProbeDataIfNotExists(probeMetadataIndex, probeId);
if (probeData.IsEmpty())
{
// In .NET Framework, we have en issue with multiple AppDomains. We can't easily share probe metadata
// between different AppDomain. The domain that request to put a probe might be different from the one that executes it.
// It results in entering into this branch. There is ongoing effort to fix this issue entirely in .NET Framework,
// for now as a quick fix to unblock a customer, this patch is being applied, to avoid logging tremendous amount of
// log entries.
#if !NETFRAMEWORK
Log.Warning("BeginMethod: Failed to receive the ProbeData associated with the executing probe. type = {Type}, instance type name = {Name}, probeMetadataIndex = {ProbeMetadataIndex}, probeId = {ProbeId}", new object[] { typeof(TTarget), instance?.GetType().Name, probeMetadataIndex, probeId });
#endif
state = AsyncMethodDebuggerState.CreateInvalidatedDebuggerState();
return;
}
Expand Down
7 changes: 7 additions & 0 deletions tracer/src/Datadog.Trace/Debugger/Instrumentation/MethodDebuggerInvoker.SingleProbe.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,14 @@ public static MethodDebuggerState BeginMethod_StartMarker<TTarget>(TTarget insta
ref var probeData = ref ProbeDataCollection.Instance.TryCreateProbeDataIfNotExists(probeMetadataIndex, probeId);
if (probeData.IsEmpty())
{
// In .NET Framework, we have en issue with multiple AppDomains. We can't easily share probe metadata
// between different AppDomain. The domain that request to put a probe might be different from the one that executes it.
// It results in entering into this branch. There is ongoing effort to fix this issue entirely in .NET Framework,
// for now as a quick fix to unblock a customer, this patch is being applied, to avoid logging tremendous amount of
// log entries.
#if !NETFRAMEWORK
Log.Warning("BeginMethod_StartMarker: Failed to receive the ProbeData associated with the executing probe. type = {Type}, instance type name = {Name}, probeMetadataIndex = {ProbeMetadataIndex}, probeId = {ProbeId}", new object[] { typeof(TTarget), instance?.GetType().Name, probeMetadataIndex, probeId });
#endif
return CreateInvalidatedDebuggerState();
}

Expand Down
Loading